Skip to content

Code snippet render result does not look like Scala #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KisaragiEffective opened this issue May 10, 2023 · 3 comments
Closed

Code snippet render result does not look like Scala #2797

KisaragiEffective opened this issue May 10, 2023 · 3 comments
Labels

Comments

@KisaragiEffective
Copy link
Contributor

KisaragiEffective commented May 10, 2023

In https://docs.scala-lang.org/scala3/guides/macros/quotes.html, the most bottom code block which is in following screen capture was rendered in broken way (seems highlight.js recognized it as Bash script):

image

Permalink of source code is here:

Another common case where we need type annotations is for infix operations:

@julienrf julienrf added the Bug label May 10, 2023
@bishabosha
Copy link
Member

bishabosha commented May 11, 2023

I had some fixes on branch https://github.com/bishabosha/docs.scala-lang/tree/improve-highlighting

Screenshot 2023-05-11 at 10 05 16

@bishabosha
Copy link
Member

It also improves upon triple quote string handling:
e.g. in https://docs.scala-lang.org/toolkit/json-parse.html
Screenshot 2023-05-11 at 10 09 29

@bishabosha
Copy link
Member

bishabosha commented May 11, 2023

fixed by #2798 but you might need to empty caches (I've observed the new changes are live)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants