Fix: Increase the number of search results #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
reviewed
Mar 6, 2023
|
I think it is only when more than 5 elements are match. |
ckipp01
approved these changes
Mar 6, 2023
julienrf
approved these changes
Mar 6, 2023
|
So maybe I'm wrong but I tested locally and nothing changes when I change this value. Is it the fact that it is local, or do I have to use the algolia API key. I don't know but I'll look into it. |
|
Let's optimistically merge and see what happens. |
|
So, I have just made some corrections and research. Is it possible to reopen this pull request or should I create a new one? |
|
PRs cannot be reopened. Followup PRs are in this area are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Scala documentation grows (the new Scala3 version, earlier versions, etc.) the search areas become more diverse, and a search should be as comprehensive as possible so that even the most novice user can easily find what they are looking for.
This is why in this PR, I have increased the number of search results.
Fixes #2715