Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrices over the univariate polynomials: unify the handling of "empty" matrices #39587

Open
vneiger opened this issue Feb 25, 2025 · 0 comments · May be fixed by #39852
Open

Matrices over the univariate polynomials: unify the handling of "empty" matrices #39587

vneiger opened this issue Feb 25, 2025 · 0 comments · May be fixed by #39852

Comments

@vneiger
Copy link
Contributor

vneiger commented Feb 25, 2025

Currently, most methods from matrix_polynomial_dense support empty matrices (i.e. with dimensions 0 x n, m x 0, or 0 x 0). Most, but not all, and why some do and some don't is not very clear for the user, and is not well indicated in the documentation.

This was raised specifically for minimal_relation_basis in #39516 (comment) . For example:

  • row_degrees does not support empty matrices (fails with an error message), it is indirectly stated in the documentation via the examples
  • leading_matrix and right_quo_rem do not support empty matrices (fails with an error message), it is not indicated in the documentation
  • minimal_approximant_basis and minimal_kernel_basis do support empty matrices.

The treatment of empty matrices should be more unified among the available methods if possible; but at the very least, the documentation should clearly indicate input restrictions about empty matrices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant