Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

free_module_pseudomorphism equality checking test failure #39807

Open
2 tasks done
user202729 opened this issue Mar 28, 2025 · 0 comments · May be fixed by #39837
Open
2 tasks done

free_module_pseudomorphism equality checking test failure #39807

user202729 opened this issue Mar 28, 2025 · 0 comments · May be fixed by #39837
Labels
t: bug

Comments

@user202729
Copy link
Contributor

Steps To Reproduce

on CI:

            sage: g = V.pseudohom(m.transpose(), Frob)
            sage: f == g
 Check failure on line 483 in src/sage/modules/free_module_pseudomorphism.py


GitHub Actions
/ Conda (ubuntu, Python 3.12)
Failed example:
Failed example:: Got: True

Looks like __eq__ forgets to check that the side are equal. @xcaruso ?

added in #38650

Side note: __lt__ etc. (fallback from _richcmp_) are not overridden. Is this intentional? (e.g. is trichotomy ever violated?)

Another bug: __eq__ returns None if wrong type (surely it shouldn't return None right, it should return NotImplemented).

Expected Behavior

Actual Behavior

Additional Information

No response

Environment

CI, latest

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide
@xcaruso xcaruso linked a pull request Mar 31, 2025 that will close this issue
Open
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this issue Apr 3, 2025
fd492c8 
sagemathgh-39837: Richcmp for pseudomorphisms
    
This PR implements rich comparison for pseudomorphisms.

Fixes sagemath#39807

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39837
Reported by: Xavier Caruso
Reviewer(s): user202729, Xavier Caruso
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Richcmp for pseudomorphisms xcaruso/sage
1 participant
@user202729