Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo on doc.sagemath.org graph theory page #39674

Open
microncomputer opened this issue Mar 11, 2025 · 3 comments · May be fixed by #39825
Open

Typo on doc.sagemath.org graph theory page #39674

microncomputer opened this issue Mar 11, 2025 · 3 comments · May be fixed by #39825
Labels
c: documentation good first issue p: minor / 4 t: bug

Comments

@microncomputer
Copy link

place of typo

the typo is at "is_edge_cut()" not super far down the page. there's an apostrophe in front of the name and it is plaintext -> not a link like the other functions in the table.
@DaveWitteMorris
Copy link
Member

Thanks for the bug report. I think the erroneous backtick before is_edge_cut is in line 246 of src/sage/graphs/generic_graph.py:

    :meth:`~GenericGraph.`is_edge_cut` | Check whether the input edges form an edge cut.

@EigenVector22
Copy link

I'll raise a PR to fix this

@EigenVector22 EigenVector22 linked a pull request Mar 30, 2025 that will close this issue
Open
5 tasks
@EigenVector22
Copy link

Hello, @DaveWitteMorris fixed this, can you please give feedback and review it,
Thanks,

vbraun pushed a commit to vbraun/sage that referenced this issue Apr 5, 2025
fdf5e9b 
sagemathgh-39825: Fix typo in :meth: link for is_edge_cut
    
Fixes sagemath#39674

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39825
Reported by: EigenVector22
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue Apr 7, 2025
368bcc8 
sagemathgh-39825: Fix typo in :meth: link for is_edge_cut
    
Fixes sagemath#39674

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39825
Reported by: Ashutosh Rajora
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue Apr 10, 2025
ec505f7 
sagemathgh-39825: Fix typo in :meth: link for is_edge_cut
    
Fixes sagemath#39674

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39825
Reported by: Ashutosh Rajora
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation good first issue p: minor / 4 t: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in :meth: link for is_edge_cut EigenVector22/sage
3 participants
@microncomputer @DaveWitteMorris @EigenVector22