Skip to content

Implement From<Vec<T>> and Into<Vec<T>> for VecDeque<T> #32848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apasel422 opened this issue Apr 9, 2016 · 3 comments
Closed

Implement From<Vec<T>> and Into<Vec<T>> for VecDeque<T> #32848

apasel422 opened this issue Apr 9, 2016 · 3 comments
Labels
A-collections Area: `std::collections`

Comments

@apasel422
Copy link
Contributor

This can be done without allocating or going through an iterator.

@apasel422 apasel422 added the A-collections Area: `std::collections` label Apr 9, 2016
@davidhewitt
Copy link
Contributor

Hi, I've just had a go at implementing this (my first contribution to Rust!). It's in my fork davidhewitt@4a21983

Does this patch look like what you were looking for? If so, I'll open a pull request. Is there anything I should know about opening PRs for Rust (what to name them, do I need to put in a specially formatted description for a bot to parse etc.)?

@apasel422
Copy link
Contributor Author

@davidhewitt Nice! That is what I was looking for. If you open a PR, I'll leave comments there. The PR title can be the same as your commit message, and the body can contain "Closes #32848" so that this issue can be closed automatically once the PR is merged.

@davidhewitt
Copy link
Contributor

Thanks - #32866!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-collections Area: `std::collections`
Projects
None yet
Development

No branches or pull requests

2 participants