Skip to content

Broken Rspec.html link for rspec-rails docs #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
myronmarston opened this issue Jan 30, 2015 · 9 comments
Closed

Broken Rspec.html link for rspec-rails docs #50

myronmarston opened this issue Jan 30, 2015 · 9 comments
Labels

Comments

@myronmarston
Copy link
Member

On the rspec-rails docs page:

http://rspec.info/documentation/3.2/rspec-rails/

Click on "Class List" and you'll see that RSpec and Rspec are both listed. The latter 404s, while the former goes to a page that talks about Rspec.

@JonRowe
Copy link
Member

JonRowe commented Feb 1, 2015

I think this is an issue with the generated docs, not with pages itself, I seem to recall there should be two pages...

@myronmarston
Copy link
Member Author

I think this is an issue with the generated docs, not with pages itself, I seem to recall there should be two pages...

I think you're right. It looks like it works when I run yard server --reload from within rspec-rails but if I run yard doc to generate the static HTML docs it has problems.

@JonRowe
Copy link
Member

JonRowe commented Feb 1, 2015

Yeah so I think thats because the OSX filesystem (by default) is case insensitive, where as git and URLS are case sensitive

@myronmarston
Copy link
Member Author

That makes sense. Maybe we should exclude the Rspec constant from the docs by labelling it @private? Or does it have important stuff in there that needs to be publicly documented?

@JonRowe
Copy link
Member

JonRowe commented Feb 2, 2015

A quite scan of rspec-rails says that it's there only for compatibility with Rails autoloading, and all the child classes are labeled @private so I think thats the go /cc @cupakromer

@cupakromer
Copy link
Member

Yes it is just for making Rails happy. We probably could try to declare it with the Rails inflections, but just marking it @private is faster and safer for now.

@exagil
Copy link

exagil commented Oct 12, 2015

A temporary solution is replacing Rspec.html with RSpec.html

@JonRowe
Copy link
Member

JonRowe commented Oct 12, 2015

@chi6rag would be better to remove the link to Rspec.html as Rspec.html and RSpec.html do have different content

@pirj
Copy link
Member

pirj commented Apr 4, 2020

Rspec stopped appearing in the Class List starting from 3.4 http://rspec.info/documentation/3.4/rspec-rails/
3.2 and 3.3 are still problematic, but it's unlikely something we'd like to fix.

@pirj pirj closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants