Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout is broken for "Inherits" in < 3.9 #148

Closed
pirj opened this issue May 22, 2020 · 5 comments · Fixed by #152
Closed

Layout is broken for "Inherits" in < 3.9 #148

pirj opened this issue May 22, 2020 · 5 comments · Fixed by #152
Assignees
@benoittgt

Comments

@pirj
Copy link
Member

pirj commented May 22, 2020

http://rspec.info/documentation/3.8/rspec-core/RSpec/Core/Example/Procsy.html
image
http://rspec.info/documentation/3.9/rspec-core/RSpec/Core/Example/Procsy.html
image
image

The same on the other doc pages:
image

Same on 3.7 and 3.8, didn't look further.
@benoittgt
Copy link
Member

This probably related to the yard version.

  • 3.8: Generated on Fri Sep 14 00:01:55 2018 by yard 0.9.16 (ruby-2.5.1).
  • 3.9: Generated on Wed Apr 8 18:11:34 2020 by yard 0.9.24 (ruby-2.6.3).

This is done here https://github.com/lsegal/yard/blob/master/templates/default/module/html/box_info.erb#L7-L10

I can look at it.

@benoittgt benoittgt self-assigned this May 23, 2020
@JonRowe
Copy link
Member

JonRowe commented May 23, 2020

Thanks @benoittgt !

@benoittgt
Copy link
Member

Hello @pirj

I am sorry but what is broken? Expect this is now hidden by default what we should see?

Thanks :)

@pirj
Copy link
Member Author

pirj commented Jun 8, 2020 •
edited
Loading

Hey @benoittgt ! 👋 :D

There's no (hide) button as far as I can tell.
Also, there's a white rectangle somewhere near Inherits.

I didn't dig the source, but it seems there's a difference:

image

image

image

@benoittgt
Copy link
Member

Oook. Thanks @pirj

benoittgt added a commit that referenced this issue Jul 28, 2020
@benoittgt
Regenerate doc with recent yard to avoid visual issue in "Inherits"
cc8b6a0 
Fix: #148
@benoittgt benoittgt mentioned this issue Jul 28, 2020
Merged
benoittgt added a commit that referenced this issue Jul 30, 2020
@benoittgt
Regenerate doc with recent yard to avoid visual issue in "Inherits"
dc09a0c 
Fix: #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoittgt benoittgt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Regenerate doc with recent yard to avoid visual issue in "Inherits" rspec/rspec.github.io
3 participants
@pirj @JonRowe @benoittgt