Skip to content

3.8 docs are slightly messed up #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
myronmarston opened this issue Aug 4, 2018 · 8 comments
Closed

3.8 docs are slightly messed up #116

myronmarston opened this issue Aug 4, 2018 · 8 comments

Comments

@myronmarston
Copy link
Member

See rspec-core on staging for example:

image

The 3.8 docs for mocks and expectations are slightly messed up, too, but the rails docs are kinda messed up.

@JonRowe any ideas?
@myronmarston
Copy link
Member Author

@JonRowe can you take a look at this?

@JonRowe
Copy link
Member

JonRowe commented Sep 9, 2018

On my list!

@benoittgt
Copy link
Member

Ping me if I can help.

@JonRowe
Copy link
Member

JonRowe commented Sep 13, 2018

Right so this is due to an updated version of yard changing the js, I think we should use the versions it generates rather than shared, staging has been updated with fixed docs and see #117 and rspec/rspec-dev#206

@JonRowe
Copy link
Member

JonRowe commented Sep 13, 2018

If someone can sanity check I'll ship to prod

@myronmarston
Copy link
Member Author

Staging LGTM

@JonRowe
Copy link
Member

JonRowe commented Sep 16, 2018

Deployed to prod

@pirj
Copy link
Member

pirj commented Nov 19, 2019

Please re-open if you feel something needs to be done in the scope of this issue.

@pirj pirj closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pirj @myronmarston @JonRowe @benoittgt