Skip to content

Latest commit

 

History

History
875 lines (607 loc) · 26.8 KB

writing_stubs.rst

File metadata and controls

875 lines (607 loc) · 26.8 KB

Writing and Maintaining Stub Files

Stub files are a means of providing type information for Python modules. For a full reference, refer to :ref:`stub-files`.

Maintaining stubs can be a little cumbersome because they are separated from the implementation. This page lists some tools that make writing and maintaining stubs less painful, as well as some best practices on stub contents and style.

Tools for generating stubs

stubgen

stubgen is a tool bundled with mypy that can be used to generate basic stubs. These stubs serve as a basic starting point; most types will default to Any.

stubgen -p my_great_package

For more details, see stubgen docs.

pyright

pyright contains a tool that generates basic stubs. Like stubgen, these generated stubs serve more as a starting point.

pyright --createstub my_great_package

For more details, see pyright docs.

monkeytype

monkeytype takes a slightly different approach — you run your code (perhaps via your tests) and monkeytype collects the types it observes at runtime to generate stubs.

monkeytype run script.py
monkeytype stub my_great_package

For more details, see monkeytype docs.

Tools for maintaining stubs

stubtest

stubtest is a tool bundled with mypy.

stubtest finds inconsistencies between stub files and the implementation. It does this by comparing stub definitions to what it finds from importing your code and using runtime introspection (via the inspect module).

stubtest my_great_package

For more details, see stubtest docs.

flake8-pyi

flake8-pyi is a flake8 plugin that lints common issues in stub files.

flake8 my_great_package

For more details, see flake8-pyi docs.

Running a type checker on the stubs

Simply running a type checker on the stubs can catch several issues, from simple things like detecting missing annotations to more complex things like ensuring Liskov substitutability or detecting problematic overloads.

It may be instructive to examine typeshed's setup for testing stubs.

To suppress type errors in stubs, use # type: ignore comments. Refer to the :ref:`type-checker-error-suppression` section of the style guide for error suppression formats specific to individual typecheckers.

Type checking usage of your package

If you have access to a codebase that uses your package — perhaps tests for your package — running a type checker against it can help you detect issues, particularly with false positives.

If your package has some particularly complex aspects, you could even consider writing dedicated typing tests for tricky definitions. For more details, see :ref:`testing`.

Stub Content

This section documents best practices on what elements to include or leave out of stub files.

Public Interface

Stubs should include the complete public interface (classes, functions, constants, etc.) of the module they cover, but it is not always clear exactly what is part of the interface.

The following should always be included:

  • All objects listed in the module's documentation.
  • All objects included in __all__ (if present).

Other objects may be included if they are not prefixed with an underscore or if they are being used in practice.

Modules excluded from stubs

The following should not be included in stubs:

  1. Implementation details, with multiprocessing/popen_spawn_win32.py as a notable example
  2. Modules that are not supposed to be imported, such as __main__.py
  3. Protected modules that start with a single _ char. However, when needed protected modules can still be added (see :ref:`undocumented-objects` section below)
  4. Tests

Undocumented Objects

Undocumented objects may be included as long as they are marked with a comment of the form # undocumented.

Example:

def list2cmdline(seq: Sequence[str]) -> str: ...  # undocumented

Such undocumented objects are allowed because omitting objects can confuse users. Users who see an error like "module X has no attribute Y" will not know whether the error appeared because their code had a bug or because the stub is wrong. Although it may also be helpful for a type checker to point out usage of private objects, false negatives (no errors for wrong code) are preferable over false positives (type errors for correct code). In addition, even for private objects a type checker can be helpful in pointing out that an incorrect type was used.

__all__

A stub file should contain an __all__ variable if and only if it is also present at runtime. In that case, the contents of __all__ should be identical in the stub and at runtime. If the runtime dynamically adds or removes elements (for example if certain functions are only available on some system configurations), include all possible elements in the stubs.

Stub-Only Objects

Definitions that do not exist at runtime may be included in stubs to aid in expressing types. Unless intentionally exposed to users (see below), such definitions should be marked as private by prefixing their names with an underscore.

Yes:

_T = TypeVar("_T")
_DictList: TypeAlias = dict[str, list[int | None]]

No:

T = TypeVar("T")
DictList: TypeAlias = dict[str, list[int | None]]

Sometimes, it is desirable to make a stub-only class available to a stub's users — for example, to allow them to type the return value of a public method for which a library does not provided a usable runtime type. Use the typing.type_check_only decorator to mark such objects:

from typing import Protocol, type_check_only

@type_check_only
class Readable(Protocol):
    def read(self) -> str: ...

def get_reader() -> Readable: ...

Structural Types

As seen in the example with Readable in the previous section, a common use of stub-only objects is to model types that are best described by their structure. These objects are called protocols (PEP 544), and it is encouraged to use them freely to describe simple structural types.

Incomplete Stubs

When writing new stubs, it is not necessary to fully annotate all arguments, return types, and fields. Some items may be left unannotated or annotated with _typeshed.Incomplete (documentation):

from _typeshed import Incomplete

field: Incomplete  # unannotated

def foo(x): ...  # unannotated argument and return type

_typeshed.Incomplete can also be used for partially known types:

def foo(x: Incomplete | None = None) -> list[Incomplete]: ...

Partial stubs can be useful, especially for larger packages, but they should follow the following guidelines:

  • Included functions and methods should list all arguments, but the arguments can be left unannotated.
  • Do not use Any to mark unannotated or partially annotated values. Leave function parameters and return values unannotated. In all other cases, use _typeshed.Incomplete.
  • Partial classes should include a __getattr__() method marked with _typeshed.Incomplete (see example below).
  • Partial modules (i.e. modules that are missing some or all classes, functions, or attributes) should include a top-level __getattr__() function marked with _typeshed.Incomplete (see example below).
  • Partial packages (i.e. packages that are missing one or more sub-modules) should have a __init__.pyi stub that is marked as incomplete (see above). A better alternative is to create empty stubs for all sub-modules and mark them as incomplete individually.

Example of a partial module with a partial class Foo and a partially annotated function bar():

from _typeshed import Incomplete

def __getattr__(name: str) -> Incomplete: ...

class Foo:
    def __getattr__(self, name: str) -> Incomplete: ...
    x: int
    y: str

def bar(x: str, y, *, z=...): ...

Any vs. Incomplete

While Incomplete is a type alias of Any, they serve different purposes: Incomplete is a placeholder where a proper type might be substituted. It's a "to do" item and should be replaced if possible.

Any is used when it's not possible to accurately type an item using the current type system. It should be used sparingly, as described in the :ref:`using-any` section of the style guide.

Attribute Access

Python has several methods for customizing attribute access: __getattr__, __getattribute__, __setattr__, and __delattr__. Of these, __getattr__ and __setattr___ should sometimes be included in stubs.

In addition to marking incomplete definitions, __getattr__ should be included when a class or module allows any name to be accessed. For example, consider the following class:

class Foo:
    def __getattribute__(self, name):
        return self.__dict__.setdefault(name)

An appropriate stub definition is:

from typing import Any

class Foo:
    def __getattr__(self, name: str) -> Any | None: ...

Note that only __getattr__, not __getattribute__, is guaranteed to be supported in stubs.

On the other hand, __getattr__ should be omitted even if the source code includes it, if only limited names are allowed. For example, consider this class:

class ComplexNumber:
    def __init__(self, n):
        self._n = n
    def __getattr__(self, name):
        if name in ("real", "imag"):
            return getattr(self._n, name)
        raise AttributeError(name)

In this case, the stub should list the attributes individually:

class ComplexNumber:
    @property
    def real(self) -> float: ...
    @property
    def imag(self) -> float: ...
    def __init__(self, n: complex) -> None: ...

__setattr___ should be included when a class allows any name to be set and restricts the type. For example:

class IntHolder:
    def __setattr__(self, name, value):
        if isinstance(value, int):
            return super().__setattr__(name, value)
        raise ValueError(value)

A good stub definition would be:

class IntHolder:
    def __setattr__(self, name: str, value: int) -> None: ...

__delattr__ should not be included in stubs.

Finally, even in the presence of __getattr__ and __setattr__, it is still recommended to separately define known attributes.

Constants

When the value of a constant is important, mark it as Final and assign it to its value.

Yes:

TEL_LANDLINE: Final = "landline"
TEL_MOBILE: Final = "mobile"
DAY_FLAG: Final = 0x01
NIGHT_FLAG: Final = 0x02

No:

TEL_LANDLINE: str
TEL_MOBILE: str
DAY_FLAG: int
NIGHT_FLAG: int

Overloads

All variants of overloaded functions and methods must have an @overload decorator. Do not include the implementation's final non-@overload-decorated definition.

Yes:

@overload
def foo(x: str) -> str: ...
@overload
def foo(x: float) -> int: ...

No:

@overload
def foo(x: str) -> str: ...
@overload
def foo(x: float) -> int: ...
def foo(x: str | float) -> Any: ...

Decorators

Include only the decorators listed :ref:`here <stub-decorators>`, whose effects are understood by all of the major type checkers. The behavior of other decorators should instead be incorporated into the types. For example, for the following function:

import contextlib
@contextlib.contextmanager
def f():
    yield 42

the stub definition should be:

from contextlib import AbstractContextManager
def f() -> AbstractContextManager[int]: ...

Documentation or Implementation

Sometimes a library's documented types will differ from the actual types in the code. In such cases, stub authors should use their best judgment. Consider these two examples:

def print_elements(x):
    """Print every element of list x."""
    for y in x:
        print(y)

def maybe_raise(x):
    """Raise an error if x (a boolean) is true."""
    if x:
        raise ValueError()

The implementation of print_elements takes any iterable, despite the documented type of list. In this case, annotate the argument as Iterable[object], to follow the :ref:`best practice<argument-return-practices>` of preferring abstract types for arguments.

For maybe_raise, on the other hand, it is better to annotate the argument as bool even though the implementation accepts any object. This guards against common mistakes like unintentionally passing in None.

If in doubt, consider asking the library maintainers about their intent.

Common Patterns

This section documents common patterns that are useful in stub files.

Overloads and Flags

Sometimes a function or method has a flag argument that changes the return type or other accepted argument types. For example, take the following function:

def open(name: str, mode: Literal["r", "w"] = "r") -> Reader | Writer:
    ...

We can express this case easily with two overloads:

@overload
def open(name: str, mode: Literal["r"] = "r") -> Reader: ...
@overload
def open(name: str, mode: Literal["w"]) -> Writer: ...

The first overload is picked when the mode is "r" or not given, and the second overload is picked when the mode is "w". But what if the first argument is optional?

def open(name: str | None = None, mode: Literal["r", "w"] = "r") -> Reader | Writer:
    ...

Ideally we would be able to use the following overloads:

@overload
def open(name: str | None = None, mode: Literal["r"] = "r") -> Reader: ...
@overload
def open(name: str | None = None, mode: Literal["w"]) -> Writer: ...

And while the first overload is fine, the second is a syntax error in Python, because non-default arguments cannot follow default arguments. To work around this, we need an extra overload:

@overload
def open(name: str | None = None, mode: Literal["r"] = "r") -> Reader: ...
@overload
def open(name: str | None, mode: Literal["w"]) -> Writer: ...
@overload
def open(*, mode: Literal["w"]) -> Writer: ...

As before, the first overload is picked when the mode is "r" or not given. Otherwise, the second overload is used when open is called with an explicit name, e.g. open("file.txt", "w") or open(None, "w"). The third overload is used when open is called without a name , e.g. open(mode="w").

Style Guide

The recommendations in this section are aimed at stub authors who wish to provide a consistent style for stubs. Type checkers should not reject stubs that do not follow these recommendations, but linters can warn about them.

Stub files should generally follow the Style Guide for Python Code (PEP 8) and the :ref:`best-practices`. There are a few exceptions, outlined below, that take the different structure of stub files into account and aim to create more concise files.

Syntax Example

The below is an excerpt from the types for the datetime module.

MAXYEAR: int MINYEAR: int

class date:
def __new__(cls, year: SupportsIndex, month: SupportsIndex, day: SupportsIndex) -> Self: ... @classmethod def fromtimestamp(cls, timestamp: float, /) -> Self: ... @classmethod def today(cls) -> Self: ... @classmethod def fromordinal(cls, n: int, /) -> Self: ... @property def year(self) -> int: ... def replace(self, year: SupportsIndex = ..., month: SupportsIndex = ..., day: SupportsIndex = ...) -> Self: ... def ctime(self) -> str: ... def weekday(self) -> int: ...

Maximum Line Length

Stub files should be limited to 130 characters per line.

Blank Lines

Do not use empty lines between functions, methods, and fields, except to group them with one empty line. Use one empty line around classes with non-empty bodies. Do not use empty lines between body-less classes, except for grouping.

Yes:

def time_func() -> None: ...
def date_func() -> None: ...

def ip_func() -> None: ...

class Foo:
    x: int
    y: int
    def __init__(self) -> None: ...

class MyError(Exception): ...
class AnotherError(Exception): ...

No:

def time_func() -> None: ...

def date_func() -> None: ...  # do not leave unnecessary empty lines

def ip_func() -> None: ...


class Foo:  # leave only one empty line above
    x: int
class MyError(Exception): ...  # leave an empty line between the classes

Module Level Attributes

Do not unnecessarily use an assignment for module-level attributes.

Yes:

CONST: Literal["const"]
x: int
y: Final = 0  # this assignment conveys additional type information

No:

CONST = "const"
x: int = 0
y: float = ...
z = 0  # type: int
a = ...  # type: int

Classes

Classes without bodies should use the ellipsis literal ... in place of the body on the same line as the class definition.

Yes:

class MyError(Exception): ...

No:

class MyError(Exception):
    ...
class AnotherError(Exception): pass

Instance attributes and class variables follow the same recommendations as module level attributes:

Yes:

class Foo:
    c: ClassVar[str]
    x: int

class Color(Enum):
    # An assignment with no type annotation is a convention used to indicate
    # an enum member.
    RED = 1

No:

class Foo:
    c: ClassVar[str] = ""
    d: ClassVar[int] = ...
    x = 4
    y: int = ...

Functions and Methods

For keyword-only and positional-or-keyword arguments, use the same argument names as in the implementation, because otherwise using keyword arguments will fail.

For default values, use the literal values of "simple" default values (None, bools, ints, bytes, strings, and floats). Use the ellipsis literal ... in place of more complex default values. Use an explicit X | None annotation when the default is None.

Yes:

def foo(x: int = 0) -> None: ...
def bar(y: str | None = None) -> None: ...

No:

def foo(x: X = X()) -> None: ...
def bar(y: str = None) -> None: ...

Do not annotate self and cls in method definitions, except when referencing a type variable.

Yes:

_T = TypeVar("_T")

class Foo:
    def bar(self) -> None: ...
    @classmethod
    def create(cls: type[_T]) -> _T: ...

No:

class Foo:
    def bar(self: Foo) -> None: ...
    @classmethod
    def baz(cls: type[Foo]) -> int: ...

The bodies of functions and methods should consist of only the ellipsis literal ... on the same line as the closing parenthesis and colon.

Yes:

def to_int1(x: str) -> int: ...
def to_int2(
    x: str,
) -> int: ...

No:

def to_int1(x: str) -> int:
    return int(x)
def to_int2(x: str) -> int:
    ...
def to_int3(x: str) -> int: pass

Avoid invariant collection types (list, dict) for function parameters, in favor of covariant types like Mapping or Sequence.

Avoid union return types. See python/mypy#1693

Use float instead of int | float for parameter annotations. See PEP 484 for more details.

Language Features

Use the latest language features available, even for stubs targeting older Python versions. For example, Python 3.7 added the async keyword (see PEP 492). Stubs should use it to mark coroutines, even if the implementation still uses the @coroutine decorator. On the other hand, the type soft keyword from PEP 695, introduced in Python 3.12, should not be used in stubs until Python 3.11 reaches end-of-life in October 2027.

Do not use quotes around forward references and do not use __future__ imports. See :ref:`stub-file-syntax` for more information.

Yes:

class Py35Class:
    x: int
    forward_reference: OtherClass

class OtherClass: ...

No:

class Py35Class:
    x = 0  # type: int
    forward_reference: 'OtherClass'

class OtherClass: ...

Use variable annotations instead of type comments, even for stubs that target older versions of Python.

Platform-dependent APIs

Use :ref:`platform checks<version-and-platform-checks>` like if sys.platform == 'win32' to denote platform-dependent APIs.

NamedTuple and TypedDict

Use the class-based syntax for typing.NamedTuple and typing.TypedDict, following the :ref:`stub-style-classes` section of this style guide.

Yes:

from typing import NamedTuple, TypedDict

class Point(NamedTuple):
    x: float
    y: float

class Thing(TypedDict):
    stuff: str
    index: int

No:

from typing import NamedTuple, TypedDict
Point = NamedTuple("Point", [('x', float), ('y', float)])
Thing = TypedDict("Thing", {'stuff': str, 'index': int})

Built-in Generics

PEP 585 built-in generics (such as list, dict, tuple, set) are supported and should be used instead of the corresponding types from typing:

from collections import defaultdict

def foo(t: type[MyClass]) -> list[int]: ...
x: defaultdict[int]

Using imports from collections.abc instead of typing is generally possible and recommended:

from collections.abc import Iterable

def foo(iter: Iterable[int]) -> None: ...

Unions

Declaring unions with the shorthand | syntax is recommended and supported by all type checkers:

def foo(x: int | str) -> int | None: ...  # recommended
def foo(x: Union[int, str]) -> Optional[int]: ...  # ok

Using Any and object

When adding type hints, avoid using the Any type when possible. Reserve the use of Any for when:

  • the correct type cannot be expressed in the current type system; and
  • to avoid union returns (see above).

Note that Any is not the correct type to use if you want to indicate that some function can accept literally anything: in those cases use object instead.

When using Any, document the reason for using it in a comment. Ideally, document what types could be used.

The Any Trick

In cases where a function or method can return None, but where forcing the user to explicitly check for None can be detrimental, use _typeshed.MaybeNone (an alias to Any), instead of None.

Consider the following (simplified) signature of re.Match[str].group:

class Match:
    def group(self, group: str | int, /) -> str | MaybeNone: ...

This avoid forcing the user to check for None:

match = re.fullmatch(r"\d+_(.*)", some_string)
assert match is not None
name_group = match.group(1)  # The user knows that this will never be None
return name_group.uper()  # This typo will be flagged by the type checker

In this case, the user of match.group() must be prepared to handle a str, but type checkers are happy with if name_group is None checks, because we're saying it can also be something else than an str.

This is sometimes called "the Any trick".

Context Managers

When adding type annotations for context manager classes, annotate the return type of __exit__ as bool only if the context manager sometimes suppresses exceptions -- if it sometimes returns True at runtime. If the context manager never suppresses exceptions, have the return type be either None or bool | None. If you are not sure whether exceptions are suppressed or not or if the context manager is meant to be subclassed, pick bool | None. See python/mypy#7214 for more details.

__enter__ methods and other methods that return self or cls(...) should be annotated with typing.Self (example).

Naming

Type variables and aliases you introduce purely for legibility reasons should be prefixed with an underscore to make it obvious to the reader they are not part of the stubbed API.

A few guidelines for protocol names below. In cases that don't fall into any of those categories, use your best judgement.

  • Use plain names for protocols that represent a clear concept (e.g. Iterator, Container).
  • Use SupportsX for protocols that provide callable methods (e.g. SupportsInt, SupportsRead, SupportsReadSeek).
  • Use HasX for protocols that have readable and/or writable attributes or getter/setter methods (e.g. HasItems, HasFileno).

Type Checker Error Suppression Formats

  • Use mypy error codes for mypy-specific # type: ignore annotations, e.g. # type: ignore[override] for Liskov Substitution Principle violations.
  • Use pyright error codes for pyright-specific suppressions, e.g. # pyright: ignore[reportGeneralTypeIssues].
  • If you need both on the same line, mypy's annotation needs to go first, e.g. # type: ignore[override] # pyright: ignore[reportGeneralTypeIssues].

@deprecated

The @typing_extensions.deprecated decorator (@warnings.deprecated since Python 3.13) can be used to mark deprecated functionality; see PEP 702.

Keep the deprecation message concise, but try to mention the projected version when the functionality is to be removed, and a suggested replacement.

Docstrings

There are several tradeoffs around including docstrings in type stubs. Consider the intended purpose of your stubs when deciding whether to include docstrings in your project's stubs.

  • They do not affect type checking results and will be ignored by type checkers.
  • Docstrings can improve certain IDE functionality, such as hover info.
  • Duplicating docstrings between source code and stubs requires extra work to keep them in sync.