Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f8c115a
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 71656e1
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Apr 30, 2025

  1. Improve verification of recovery_target_timeline GUC. 

    Currently check_recovery_target_timeline() converts any value that is not
current, latest, or a valid integer to 0. So for example:

recovery_target_timeline = 'currrent'

results in the following error:

FATAL:  22023: recovery target timeline 0 does not exist

Since there is no range checking for uint32 (but there is a cast from unsigned long) this setting:

recovery_target_timeline = '9999999999'

results in the following error:

FATAL:  22023: recovery target timeline 1410065407 does not exist

Improve by adding endptr checking to catch conversion errors and add range checking to
exclude values < 2 and greater than UINT_MAX.
    @dwsteele
    dwsteele authored and Commitfest Bot committed Apr 30, 2025
    Configuration menu
    Copy the full SHA
    b046085 View commit details
    Browse the repository at this point in the history

  2. [CF 5519] Improve verification of recovery_target_timeline GUC. 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5519

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): David Steele
    Commitfest Bot committed Apr 30, 2025
    Configuration menu
    Copy the full SHA
    71656e1 View commit details
    Browse the repository at this point in the history
Loading