[CF 4986] v1 - WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/4986

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAEze2WgNjODiAiTU18E06_BrRK0nqwJ1kdS_bN61c2_DpFDSnQ@mail.gmail.com
Author(s): Matthias van de Meent

Author: Commitfest Bot

src/backend/storage/buffer/bufmgr.c

@@ -5204,9 +5204,13 @@ RelationCopyStorageUsingBuffer(RelFileLocator srclocator,
 		memcpy(dstPage, srcPage, BLCKSZ);
 		MarkBufferDirty(dstBuf);
 
-		/* WAL-log the copied page. */
+		/*
+		 * WAL-log the copied page.
+		 * Note that we don't know about the type of data contained in the
+		 * page, so we can't report that the buffer is a standard page.
+		 */
 		if (use_wal)
-			log_newpage_buffer(dstBuf, true);
+			log_newpage_buffer(dstBuf, false);
 
 		END_CRIT_SECTION();