Skip to content

Problems in ProbackupTest and TestBasic(ProbackupTest) #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitry-lipetsk opened this issue May 8, 2025 · 0 comments · Fixed by #259
Closed

Problems in ProbackupTest and TestBasic(ProbackupTest) #258

dmitry-lipetsk opened this issue May 8, 2025 · 0 comments · Fixed by #259
Assignees
@dmitry-lipetsk

Comments

@dmitry-lipetsk
Copy link
Collaborator

Problem 1

testgres/testgres/plugins/pg_probackup2/pg_probackup2/tests/test_basic.py

Line 14 in 354de69

pg_node: testgres.PostgresNode

Must be testgres.NodeApp. See:

testgres/testgres/plugins/pg_probackup2/pg_probackup2/tests/test_basic.py

Line 63 in 354de69

self.pg_node = testgres.NodeApp(self.test_path, self.nodes_to_cleanup)

Problem 2

TestBasic(ProbackupTest)::test_full_backup must stop and clean test node.

testgres/testgres/plugins/pg_probackup2/pg_probackup2/tests/test_basic.py

Line 77 in 354de69

def test_full_backup(self):

dmitry-lipetsk added a commit to dmitry-lipetsk/testgres that referenced this issue May 11, 2025
@dmitry-lipetsk
[postgrespro#258] Declaration of ProbackupTest::pg_node is corrected
2a09595 
ProbackupTest::pg_node is testgres.NodeApp, not testgres.PostgresNode.

Asserts are added.
dmitry-lipetsk added a commit to dmitry-lipetsk/testgres that referenced this issue May 11, 2025
@dmitry-lipetsk
[postgrespro#258] TestBasic::test_full_backup cleans node object
753f03a 
Node cleanup is added.

TODO: we should to stop node only and cleanup his data in conftest.

---
Asserts are added.
@dmitry-lipetsk dmitry-lipetsk mentioned this issue May 11, 2025
Merged
@dmitry-lipetsk dmitry-lipetsk self-assigned this May 11, 2025
dmitry-lipetsk added a commit that referenced this issue May 12, 2025
@dmitry-lipetsk
[#258] Problems in ProbackupTest and TestBasic(ProbackupTest) are fix…
d48477d 
…ed (#259)

* [#258] Declaration of ProbackupTest::pg_node is corrected

ProbackupTest::pg_node is testgres.NodeApp, not testgres.PostgresNode.

Asserts are added.

* [#258] TestBasic::test_full_backup cleans node object

Node cleanup is added.

TODO: we should to stop node only and cleanup his data in conftest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitry-lipetsk dmitry-lipetsk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#258] Problems in ProbackupTest and TestBasic(ProbackupTest) are fixed dmitry-lipetsk/testgres
1 participant
@dmitry-lipetsk