Skip to content

Commit e95d550

Browse files
committed
Fix comment on when HOT update is possible.
The conditions listed in this comment have changed several times, and at some point the thing that the "if so" referred to was negated. The text was OK up to 9.6. It was differently wrong in v10, v11 and master, so fix in all those versions.
1 parent 7d9eca5 commit e95d550

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/backend/access/heap/heapam.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -3587,7 +3587,7 @@ heap_update(Relation relation, ItemPointer otid, HeapTuple newtup,
35873587
* Since the new tuple is going into the same page, we might be able
35883588
* to do a HOT update. Check if any of the index columns have been
35893589
* changed. If the page was already full, we may have skipped checking
3590-
* for index columns. If so, HOT update is possible.
3590+
* for index columns, and also can't do a HOT update.
35913591
*/
35923592
if (hot_attrs_checked && !bms_overlap(modified_attrs, hot_attrs))
35933593
use_hot_update = true;

0 commit comments

Comments
 (0)