Fix for no NULL in CREATE TABLE.

bmomjian · bmomjian · commit e045278e7e0d · 1997-08-22T17:15:41.000Z
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -21,7 +21,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.39 1997/08/21 02:28:41 momjian Exp $
+ *    $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.40 1997/08/22 17:15:41 momjian Exp $
  *
  * Modifications - 6/10/96 - dave@bensoft.com - version 1.13.dhb
  *
@@ -1779,8 +1779,8 @@ void dumpTables(FILE* fout, TableInfo *tblinfo, int numTables,
                                 tblinfo[i].typnames[j]);
                         actual_atts++;
                     }
-		    sprintf(q, "%s%s NULL", q,
-					(tblinfo[i].notnull[j])	? " NOT" : "");
+		    if (tblinfo[i].notnull[j])
+			sprintf(q, "%s NOT NULL", q);
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`	`*`
`22`	`22`	`*`
`23`	`23`	`* IDENTIFICATION`
`24`		`- * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.39 1997/08/21 02:28:41 momjian Exp $`
	`24`	`+ * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.40 1997/08/22 17:15:41 momjian Exp $`
`25`	`25`	`*`
`26`	`26`	`* Modifications - 6/10/96 - [email protected] - version 1.13.dhb`
`27`	`27`	`*`
`@@ -1779,8 +1779,8 @@ void dumpTables(FILE* fout, TableInfo *tblinfo, int numTables,`
`1779`	`1779`	`tblinfo[i].typnames[j]);`
`1780`	`1780`	`actual_atts++;`
`1781`	`1781`	`}`
`1782`		`- sprintf(q, "%s%s NULL", q,`
`1783`		`- (tblinfo[i].notnull[j]) ? " NOT" : "");`
	`1782`	`+ if (tblinfo[i].notnull[j])`
	`1783`	`+ sprintf(q, "%s NOT NULL", q);`
`1784`	`1784`	`}`
`1785`	`1785`	`}`
`1786`	`1786`