Skip to content

Commit d37781f

Browse files
committed
Tidy up a few calls to smrgextend().
In the new API introduced by my patch to include the backend ID in temprel filenames, the last argument to smrgextend() became skipFsync rather than isTemp, but these calls didn't get the memo. It's not really a problem to pass rel->rd_istemp rather than just plain false, because smgrextend() now automatically skips the fsync for temprels anyway, but this seems cleaner and saves some minute number of cycles.
1 parent 3573c83 commit d37781f

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/backend/access/hash/hashpage.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/access/hash/hashpage.c,v 1.83 2010/02/26 02:00:33 momjian Exp $
11+
* $PostgreSQL: pgsql/src/backend/access/hash/hashpage.c,v 1.84 2010/08/19 02:58:37 rhaas Exp $
1212
*
1313
* NOTES
1414
* Postgres hash pages look like ordinary relation pages. The opaque
@@ -733,7 +733,7 @@ _hash_alloc_buckets(Relation rel, BlockNumber firstblock, uint32 nblocks)
733733
MemSet(zerobuf, 0, sizeof(zerobuf));
734734

735735
RelationOpenSmgr(rel);
736-
smgrextend(rel->rd_smgr, MAIN_FORKNUM, lastblock, zerobuf, rel->rd_istemp);
736+
smgrextend(rel->rd_smgr, MAIN_FORKNUM, lastblock, zerobuf, false);
737737

738738
return true;
739739
}

src/backend/access/heap/visibilitymap.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/access/heap/visibilitymap.c,v 1.11 2010/08/13 20:10:50 rhaas Exp $
11+
* $PostgreSQL: pgsql/src/backend/access/heap/visibilitymap.c,v 1.12 2010/08/19 02:58:37 rhaas Exp $
1212
*
1313
* INTERFACE ROUTINES
1414
* visibilitymap_clear - clear a bit in the visibility map
@@ -477,7 +477,7 @@ vm_extend(Relation rel, BlockNumber vm_nblocks)
477477
while (vm_nblocks_now < vm_nblocks)
478478
{
479479
smgrextend(rel->rd_smgr, VISIBILITYMAP_FORKNUM, vm_nblocks_now,
480-
(char *) pg, rel->rd_istemp);
480+
(char *) pg, false);
481481
vm_nblocks_now++;
482482
}
483483

src/backend/storage/freespace/freespace.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/storage/freespace/freespace.c,v 1.78 2010/08/13 20:10:52 rhaas Exp $
11+
* $PostgreSQL: pgsql/src/backend/storage/freespace/freespace.c,v 1.79 2010/08/19 02:58:37 rhaas Exp $
1212
*
1313
*
1414
* NOTES:
@@ -588,7 +588,7 @@ fsm_extend(Relation rel, BlockNumber fsm_nblocks)
588588
while (fsm_nblocks_now < fsm_nblocks)
589589
{
590590
smgrextend(rel->rd_smgr, FSM_FORKNUM, fsm_nblocks_now,
591-
(char *) pg, rel->rd_istemp);
591+
(char *) pg, false);
592592
fsm_nblocks_now++;
593593
}
594594

0 commit comments

Comments
 (0)