Fix compiler warning in pg_logicalinspect.

MasahikoSawada · MasahikoSawada · commit 9e088f7dd8cd · 2025-03-12T14:23:56.000-07:00
Oversight in bd65cb3. Reported-by: David Rowley <dgrowleyml@gmail.com> Reported-by: Nathan Bossart <nathandbossart@gmail.com> Author: David Rowley <dgrowleyml@gmail.com> Discussion: https://postgr.es/m/CAApHDvqrhFfnetbcwgGkJ=z63T8HfQ_OyP=vX8BYiXyxFKt67w@mail.gmail.com
diff --git a/contrib/pg_logicalinspect/pg_logicalinspect.c b/contrib/pg_logicalinspect/pg_logicalinspect.c
@@ -85,6 +85,8 @@ parse_snapshot_filename(const char *filename)
 parse_error:
 	ereport(ERROR,
 			errmsg("invalid snapshot file name \"%s\"", filename));
+
+	return InvalidXLogRecPtr;					/* keep compiler quiet */
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,8 @@ parse_snapshot_filename(const char *filename)`
`85`	`85`	`parse_error:`
`86`	`86`	`ereport(ERROR,`
`87`	`87`	`errmsg("invalid snapshot file name \"%s\"", filename));`
	`88`	`+`
	`89`	`+ return InvalidXLogRecPtr; /* keep compiler quiet */`
`88`	`90`	`}`
`89`	`91`
`90`	`92`	`/*`