Ignore blank lines in pgindent exclude files

adunstan · adunstan · commit 8e4d72573cc8 · 2025-02-20T11:36:07.000-05:00
Currently a blank line matches everything, which is almost never what someone would want. If they really want that they can use a wildcard regex to do it. Author: Zsolt Parragi <zsolt.parragi@percona.com> Discussion: https://postgr.es/m/CAN4CZFNka+2q3=-Dithr4w65RJfwPaV92T62spEzLn+T4MgcMg@mail.gmail.com
diff --git a/src/tools/pgindent/pgindent b/src/tools/pgindent/pgindent
@@ -182,7 +182,7 @@ sub process_exclude
 		while (my $line = <$eh>)
 		{
 			chomp $line;
-			next if $line =~ m/^#/;
+			next if $line =~ m/^#/ || $line eq "";
 			my $rgx = qr!$line!;
 			@files = grep { $_ !~ /$rgx/ } @files if $rgx;
 		}

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ sub process_exclude`
`182`	`182`	`while (my $line = <$eh>)`
`183`	`183`	`{`
`184`	`184`	`chomp $line;`
`185`		`- next if $line =~ m/^#/;`
	`185`	`+ next if $line =~ m/^#/ \|\| $line eq "";`
`186`	`186`	`my $rgx = qr!$line!;`
`187`	`187`	`@files = grep { $_ !~ /$rgx/ } @files if $rgx;`
`188`	`188`	`}`