Remove null-pointer checks that are not needed.

Michael Meskes · Michael Meskes · commit 8794bf1ca164 · 2015-02-25T11:50:28.000+01:00
If a pointer is guaranteed to carry information there is no need to check
for NULL again. Patch by Michael Paquier.
diff --git a/src/interfaces/ecpg/ecpglib/data.c b/src/interfaces/ecpg/ecpglib/data.c
@@ -575,7 +575,7 @@ ecpg_get_data(const PGresult *results, int act_tuple, int act_field, int lineno,
 					if (nres == NULL)
 					{
 						ecpg_log("ecpg_get_data on line %d: RESULT %s; errno %d\n",
-								 lineno, pval ? pval : "", errno);
+								 lineno, pval, errno);
 
 						if (INFORMIX_MODE(compat))
 						{
@@ -634,7 +634,7 @@ ecpg_get_data(const PGresult *results, int act_tuple, int act_field, int lineno,
 					if (ires == NULL)
 					{
 						ecpg_log("ecpg_get_data on line %d: RESULT %s; errno %d\n",
-								 lineno, pval ? pval : "", errno);
+								 lineno, pval, errno);
 
 						if (INFORMIX_MODE(compat))
 						{
@@ -688,7 +688,7 @@ ecpg_get_data(const PGresult *results, int act_tuple, int act_field, int lineno,
 					if (errno != 0)
 					{
 						ecpg_log("ecpg_get_data on line %d: RESULT %s; errno %d\n",
-								 lineno, pval ? pval : "", errno);
+								 lineno, pval, errno);
 
 						if (INFORMIX_MODE(compat))
 						{
@@ -736,7 +736,7 @@ ecpg_get_data(const PGresult *results, int act_tuple, int act_field, int lineno,
 					if (errno != 0)
 					{
 						ecpg_log("ecpg_get_data on line %d: RESULT %s; errno %d\n",
-								 lineno, pval ? pval : "", errno);
+								 lineno, pval, errno);
 
 						if (INFORMIX_MODE(compat))
 						{

Original file line number	Diff line number	Diff line change
`@@ -575,7 +575,7 @@ ecpg_get_data(const PGresult *results, int act_tuple, int act_field, int lineno,`
`575`	`575`	`if (nres == NULL)`
`576`	`576`	`{`
`577`	`577`	`ecpg_log("ecpg_get_data on line %d: RESULT %s; errno %d\n",`
`578`		`- lineno, pval ? pval : "", errno);`
	`578`	`+ lineno, pval, errno);`
`579`	`579`
`580`	`580`	`if (INFORMIX_MODE(compat))`
`581`	`581`	`{`
`@@ -634,7 +634,7 @@ ecpg_get_data(const PGresult *results, int act_tuple, int act_field, int lineno,`
`634`	`634`	`if (ires == NULL)`
`635`	`635`	`{`
`636`	`636`	`ecpg_log("ecpg_get_data on line %d: RESULT %s; errno %d\n",`
`637`		`- lineno, pval ? pval : "", errno);`
	`637`	`+ lineno, pval, errno);`
`638`	`638`
`639`	`639`	`if (INFORMIX_MODE(compat))`
`640`	`640`	`{`
`@@ -688,7 +688,7 @@ ecpg_get_data(const PGresult *results, int act_tuple, int act_field, int lineno,`
`688`	`688`	`if (errno != 0)`
`689`	`689`	`{`
`690`	`690`	`ecpg_log("ecpg_get_data on line %d: RESULT %s; errno %d\n",`
`691`		`- lineno, pval ? pval : "", errno);`
	`691`	`+ lineno, pval, errno);`
`692`	`692`
`693`	`693`	`if (INFORMIX_MODE(compat))`
`694`	`694`	`{`
`@@ -736,7 +736,7 @@ ecpg_get_data(const PGresult *results, int act_tuple, int act_field, int lineno,`
`736`	`736`	`if (errno != 0)`
`737`	`737`	`{`
`738`	`738`	`ecpg_log("ecpg_get_data on line %d: RESULT %s; errno %d\n",`
`739`		`- lineno, pval ? pval : "", errno);`
	`739`	`+ lineno, pval, errno);`
`740`	`740`
`741`	`741`	`if (INFORMIX_MODE(compat))`
`742`	`742`	`{`