Fix assert with side effects in the new PHJ code.

anarazel · anarazel · commit 4e2970f8807f · 2017-12-24T02:57:55.000-08:00
Instead of asserting the assert just set the value to what it was
supposed to test...

Per coverity.
diff --git a/src/backend/executor/nodeHash.c b/src/backend/executor/nodeHash.c
@@ -1275,7 +1275,7 @@ ExecParallelHashRepartitionFirst(HashJoinTable hashtable)
 	dsa_pointer chunk_shared;
 	HashMemoryChunk chunk;
 
-	Assert(hashtable->nbatch = hashtable->parallel_state->nbatch);
+	Assert(hashtable->nbatch == hashtable->parallel_state->nbatch);
 
 	while ((chunk = ExecParallelHashPopChunkQueue(hashtable, &chunk_shared)))
 	{

Original file line number	Diff line number	Diff line change
`@@ -1275,7 +1275,7 @@ ExecParallelHashRepartitionFirst(HashJoinTable hashtable)`
`1275`	`1275`	`dsa_pointer chunk_shared;`
`1276`	`1276`	`HashMemoryChunk chunk;`
`1277`	`1277`
`1278`		`- Assert(hashtable->nbatch = hashtable->parallel_state->nbatch);`
	`1278`	`+ Assert(hashtable->nbatch == hashtable->parallel_state->nbatch);`
`1279`	`1279`
`1280`	`1280`	`while ((chunk = ExecParallelHashPopChunkQueue(hashtable, &chunk_shared)))`
`1281`	`1281`	`{`