Skip to content

Commit 4a05a64

Browse files
Remove obsolete "hole in center of page" comment.
A comment from the Berkeley days incorrectly claimed that the page management code cares about the contents of the hole in the center of the page (at least in the case of the left half of an nbtree page split). Commit 8fa30f9 added an addendum that stated that the original comment was "probably obsolete". It's definitely obsolete, though, so remove the original comment plus the addendum.
1 parent 2d59643 commit 4a05a64

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

src/backend/access/nbtree/nbtinsert.c

+2-9
Original file line numberDiff line numberDiff line change
@@ -1909,15 +1909,8 @@ _bt_split(Relation rel, BTScanInsert itup_key, Buffer buf, Buffer cbuf,
19091909
* By here, the original data page has been split into two new halves, and
19101910
* these are correct. The algorithm requires that the left page never
19111911
* move during a split, so we copy the new left page back on top of the
1912-
* original. Note that this is not a waste of time, since we also require
1913-
* (in the page management code) that the center of a page always be
1914-
* clean, and the most efficient way to guarantee this is just to compact
1915-
* the data by reinserting it into a new left page. (XXX the latter
1916-
* comment is probably obsolete; but in any case it's good to not scribble
1917-
* on the original page until we enter the critical section.)
1918-
*
1919-
* We need to do this before writing the WAL record, so that XLogInsert
1920-
* can WAL log an image of the page if necessary.
1912+
* original. We need to do this before writing the WAL record, so that
1913+
* XLogInsert can WAL log an image of the page if necessary.
19211914
*/
19221915
PageRestoreTempPage(leftpage, origpage);
19231916
/* leftpage, lopaque must not be used below here */

0 commit comments

Comments
 (0)