Skip to content

Commit 42a9e88

Browse files
committed
Add (void) cast in front of rmtree() call at the end of pg_upgrade
Most calls of rmtree() report an error, and the code coming from 38bfae3 has introduced one caller where this is not done. The previous behavior was to not fail hard if any log file generated is not properly unlinked when cleaning up the contents generated once the upgrade has completed, so add a cast to (void) to indicate the intention behind this new code. Per gripe from Coverity.
1 parent 38bfae3 commit 42a9e88

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/bin/pg_upgrade/pg_upgrade.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -754,5 +754,5 @@ cleanup(void)
754754

755755
/* Remove dump and log files? */
756756
if (!log_opts.retain)
757-
rmtree(log_opts.basedir, true);
757+
(void) rmtree(log_opts.basedir, true);
758758
}

0 commit comments

Comments
 (0)