Fixup for pg_set_relation_stats().

jeff-davis · jeff-davis · commit 35a015a60045 · 2024-10-13T13:44:23.000-07:00
Reported-by: Noriyoshi Shinoda Discussion: https://postgr.es/m/DM4PR84MB17345E2DFF28A5557B7CBC3CEE7A2@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM
diff --git a/src/backend/statistics/relation_stats.c b/src/backend/statistics/relation_stats.c
@@ -99,11 +99,11 @@ relation_statistics_update(FunctionCallInfo fcinfo, int elevel)
 	{
 		int32		relpages = PG_GETARG_INT32(RELPAGES_ARG);
 
-		if (relpages < -1)
+		if (relpages < 0)
 		{
 			ereport(elevel,
 					(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
-					 errmsg("relpages cannot be < -1")));
+					 errmsg("relpages cannot be < 0")));
 			table_close(crel, RowExclusiveLock);
 			return false;
 		}

Original file line number	Diff line number	Diff line change
`@@ -99,11 +99,11 @@ relation_statistics_update(FunctionCallInfo fcinfo, int elevel)`
`99`	`99`	`{`
`100`	`100`	`int32 relpages = PG_GETARG_INT32(RELPAGES_ARG);`
`101`	`101`
`102`		`- if (relpages < -1)`
	`102`	`+ if (relpages < 0)`
`103`	`103`	`{`
`104`	`104`	`ereport(elevel,`
`105`	`105`	`(errcode(ERRCODE_INVALID_PARAMETER_VALUE),`
`106`		`- errmsg("relpages cannot be < -1")));`
	`106`	`+ errmsg("relpages cannot be < 0")));`
`107`	`107`	`table_close(crel, RowExclusiveLock);`
`108`	`108`	`return false;`
`109`	`109`	`}`