Fix thinko in new ECPG "PREPARE AS" code.

tglsfdc · tglsfdc · commit 331695a4d9ca · 2019-05-26T10:06:37.000-04:00
ecpg_register_prepared_stmt() is pretty obviously checking the wrong variable while trying to detect malloc failure. Error in commit a1dc6ab, spotted by Coverity.
diff --git a/src/interfaces/ecpg/ecpglib/prepare.c b/src/interfaces/ecpg/ecpglib/prepare.c
@@ -85,7 +85,7 @@ ecpg_register_prepared_stmt(struct statement *stmt)
 		return false;
 
 	prep_stmt = (struct statement *) ecpg_alloc(sizeof(struct statement), lineno);
-	if (!stmt)
+	if (!prep_stmt)
 	{
 		ecpg_free(this);
 		return false;

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ ecpg_register_prepared_stmt(struct statement *stmt)`
`85`	`85`	`return false;`
`86`	`86`
`87`	`87`	`prep_stmt = (struct statement *) ecpg_alloc(sizeof(struct statement), lineno);`
`88`		`- if (!stmt)`
	`88`	`+ if (!prep_stmt)`
`89`	`89`	`{`
`90`	`90`	`ecpg_free(this);`
`91`	`91`	`return false;`