Unify PostgresNode's new() and get_new_node() methods

There is only one constructor now for PostgresNode, with the idiomatic
name 'new'. The method is not exported by the class, and must be called
as "PostgresNode->new('name',[args])". All the TAP tests that use
PostgresNode are modified accordingly. Third party scripts will need
adjusting, which is a fairly mechanical process (I just used a sed
script).

Author: adunstan

contrib/amcheck/t/001_verify_heapam.pl

@@ -15,7 +15,7 @@
 #
 # Test set-up
 #
-$node = get_new_node('test');
+$node = PostgresNode->new('test');
 $node->init;
 $node->append_conf('postgresql.conf', 'autovacuum=off');
 $node->start;

contrib/auto_explain/t/001_auto_explain.pl

@@ -8,7 +8,7 @@
 use TestLib;
 use Test::More tests => 4;
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 $node->append_conf('postgresql.conf',
 	"shared_preload_libraries = 'auto_explain'");

contrib/bloom/t/001_wal.pl

@@ -43,7 +43,7 @@ sub test_index_replay
 }
 
 # Initialize primary node
-$node_primary = get_new_node('primary');
+$node_primary = PostgresNode->new('primary');
 $node_primary->init(allows_streaming => 1);
 $node_primary->start;
 my $backup_name = 'my_backup';
@@ -52,7 +52,7 @@ sub test_index_replay
 $node_primary->backup($backup_name);
 
 # Create streaming standby linking to primary
-$node_standby = get_new_node('standby');
+$node_standby = PostgresNode->new('standby');
 $node_standby->init_from_backup($node_primary, $backup_name,
 	has_streaming => 1);
 $node_standby->start;

contrib/test_decoding/t/001_repl_stats.pl

@@ -11,7 +11,7 @@
 use Test::More tests => 2;
 
 # Test set-up
-my $node = get_new_node('test');
+my $node = PostgresNode->new('test');
 $node->init(allows_streaming => 'logical');
 $node->append_conf('postgresql.conf', 'synchronous_commit = on');
 $node->start;

src/bin/pg_amcheck/t/002_nonesuch.pl

@@ -10,7 +10,7 @@
 
 # Test set-up
 my ($node, $port);
-$node = get_new_node('test');
+$node = PostgresNode->new('test');
 $node->init;
 $node->start;
 $port = $node->port;

src/bin/pg_amcheck/t/003_check.pl

@@ -120,7 +120,7 @@ ()
 }
 
 # Test set-up
-$node = get_new_node('test');
+$node = PostgresNode->new('test');
 $node->init;
 $node->append_conf('postgresql.conf', 'autovacuum=off');
 $node->start;

src/bin/pg_amcheck/t/004_verify_heapam.pl

@@ -178,7 +178,7 @@ sub write_tuple
 # Set up the node.  Once we create and corrupt the table,
 # autovacuum workers visiting the table could crash the backend.
 # Disable autovacuum so that won't happen.
-my $node = get_new_node('test');
+my $node = PostgresNode->new('test');
 $node->init;
 $node->append_conf('postgresql.conf', 'autovacuum=off');
 

src/bin/pg_amcheck/t/005_opclass_damage.pl

@@ -10,7 +10,7 @@
 use TestLib;
 use Test::More tests => 5;
 
-my $node = get_new_node('test');
+my $node = PostgresNode->new('test');
 $node->init;
 $node->start;
 

src/bin/pg_basebackup/t/010_pg_basebackup.pl

@@ -18,7 +18,7 @@
 
 my $tempdir = TestLib::tempdir;
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 
 # Set umask so test directories and files are created with default permissions
 umask(0077);
@@ -268,7 +268,7 @@
 	skip "no tar program available", 1
 	  if (!defined $tar || $tar eq '');
 
-	my $node2 = get_new_node('replica');
+	my $node2 = PostgresNode->new('replica');
 
 	# Recover main data directory
 	$node2->init_from_backup($node, 'tarbackup2', tar_program => $tar);

src/bin/pg_basebackup/t/020_pg_receivewal.pl

@@ -14,7 +14,7 @@
 # Set umask so test directories and files are created with default permissions
 umask(0077);
 
-my $primary = get_new_node('primary');
+my $primary = PostgresNode->new('primary');
 $primary->init(allows_streaming => 1);
 $primary->start;
 

src/bin/pg_basebackup/t/030_pg_recvlogical.pl

@@ -11,7 +11,7 @@
 program_version_ok('pg_recvlogical');
 program_options_handling_ok('pg_recvlogical');
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 
 # Initialize node without replication settings
 $node->init(allows_streaming => 1, has_archiving => 1);

src/bin/pg_checksums/t/002_actions.pl

@@ -92,7 +92,7 @@ sub check_relation_corruption
 }
 
 # Initialize node with checksums disabled.
-my $node = get_new_node('node_checksum');
+my $node = PostgresNode->new('node_checksum');
 $node->init();
 my $pgdata = $node->data_dir;
 

src/bin/pg_controldata/t/001_pg_controldata.pl

@@ -14,7 +14,7 @@
 command_fails([ 'pg_controldata', 'nonexistent' ],
 	'pg_controldata with nonexistent directory fails');
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 
 command_like([ 'pg_controldata', $node->data_dir ],

src/bin/pg_ctl/t/002_status.pl

@@ -14,7 +14,7 @@
 command_exit_is([ 'pg_ctl', 'status', '-D', "$tempdir/nonexistent" ],
 	4, 'pg_ctl status with nonexistent directory');
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 
 command_exit_is([ 'pg_ctl', 'status', '-D', $node->data_dir ],

src/bin/pg_ctl/t/003_promote.pl

@@ -15,7 +15,7 @@
 	qr/directory .* does not exist/,
 	'pg_ctl promote with nonexistent directory');
 
-my $node_primary = get_new_node('primary');
+my $node_primary = PostgresNode->new('primary');
 $node_primary->init(allows_streaming => 1);
 
 command_fails_like(
@@ -30,7 +30,7 @@
 	qr/not in standby mode/,
 	'pg_ctl promote of primary instance fails');
 
-my $node_standby = get_new_node('standby');
+my $node_standby = PostgresNode->new('standby');
 $node_primary->backup('my_backup');
 $node_standby->init_from_backup($node_primary, 'my_backup',
 	has_streaming => 1);
@@ -47,7 +47,7 @@
 	'promoted standby is not in recovery');
 
 # same again with default wait option
-$node_standby = get_new_node('standby2');
+$node_standby = PostgresNode->new('standby2');
 $node_standby->init_from_backup($node_primary, 'my_backup',
 	has_streaming => 1);
 $node_standby->start;

src/bin/pg_ctl/t/004_logrotate.pl

@@ -10,7 +10,7 @@
 use Time::HiRes qw(usleep);
 
 # Set up node with logging collector
-my $node = get_new_node('primary');
+my $node = PostgresNode->new('primary');
 $node->init();
 $node->append_conf(
 	'postgresql.conf', qq(

src/bin/pg_dump/t/002_pg_dump.pl

@@ -3562,7 +3562,7 @@
 #########################################
 # Create a PG instance to test actually dumping from
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 $node->start;
 

src/bin/pg_dump/t/003_pg_dump_with_server.pl

@@ -11,7 +11,7 @@
 my $tempdir       = TestLib::tempdir;
 my $tempdir_short = TestLib::tempdir_short;
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 my $port = $node->port;
 
 $node->init;

src/bin/pg_dump/t/010_dump_connstr.pl

@@ -51,7 +51,7 @@
 my $src_bootstrap_super = 'regress_postgres';
 my $dst_bootstrap_super = 'boot';
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init(extra =>
 	  [ '-U', $src_bootstrap_super, '--locale=C', '--encoding=LATIN1' ]);
 
@@ -181,7 +181,7 @@
 # Restore full dump through psql using environment variables for
 # dbname/user connection parameters
 
-my $envar_node = get_new_node('destination_envar');
+my $envar_node = PostgresNode->new('destination_envar');
 $envar_node->init(
 	extra =>
 	  [ '-U', $dst_bootstrap_super, '--locale=C', '--encoding=LATIN1' ],
@@ -208,7 +208,7 @@
 # dbname/user connection parameters.  "\connect dbname=" forgets
 # user/port from command line.
 
-my $cmdline_node = get_new_node('destination_cmdline');
+my $cmdline_node = PostgresNode->new('destination_cmdline');
 $cmdline_node->init(
 	extra =>
 	  [ '-U', $dst_bootstrap_super, '--locale=C', '--encoding=LATIN1' ],

src/bin/pg_resetwal/t/001_basic.pl

@@ -12,7 +12,7 @@
 program_version_ok('pg_resetwal');
 program_options_handling_ok('pg_resetwal');
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 
 command_like([ 'pg_resetwal', '-n', $node->data_dir ],

src/bin/pg_resetwal/t/002_corrupted.pl

@@ -10,7 +10,7 @@
 use TestLib;
 use Test::More tests => 6;
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 
 my $pg_control = $node->data_dir . '/global/pg_control';

src/bin/pg_rewind/t/007_standby_source.pl

@@ -58,13 +58,13 @@
 #
 # A (primary) <--- B (standby) <--- C (standby)
 $node_a->backup('my_backup');
-$node_b = get_new_node('node_b');
+$node_b = PostgresNode->new('node_b');
 $node_b->init_from_backup($node_a, 'my_backup', has_streaming => 1);
 $node_b->set_standby_mode();
 $node_b->start;
 
 $node_b->backup('my_backup');
-$node_c = get_new_node('node_c');
+$node_c = PostgresNode->new('node_c');
 $node_c->init_from_backup($node_b, 'my_backup', has_streaming => 1);
 $node_c->set_standby_mode();
 $node_c->start;

src/bin/pg_rewind/t/008_min_recovery_point.pl

@@ -40,7 +40,7 @@
 
 my $tmp_folder = TestLib::tempdir;
 
-my $node_1 = get_new_node('node_1');
+my $node_1 = PostgresNode->new('node_1');
 $node_1->init(allows_streaming => 1);
 $node_1->append_conf(
 	'postgresql.conf', qq(
@@ -60,11 +60,11 @@
 my $backup_name = 'my_backup';
 $node_1->backup($backup_name);
 
-my $node_2 = get_new_node('node_2');
+my $node_2 = PostgresNode->new('node_2');
 $node_2->init_from_backup($node_1, $backup_name, has_streaming => 1);
 $node_2->start;
 
-my $node_3 = get_new_node('node_3');
+my $node_3 = PostgresNode->new('node_3');
 $node_3->init_from_backup($node_1, $backup_name, has_streaming => 1);
 $node_3->start;
 

src/bin/pg_rewind/t/RewindTest.pm

@@ -128,7 +128,7 @@ sub setup_cluster
 
 	# Initialize primary, data checksums are mandatory
 	$node_primary =
-	  get_new_node('primary' . ($extra_name ? "_${extra_name}" : ''));
+	  PostgresNode->new('primary' . ($extra_name ? "_${extra_name}" : ''));
 
 	# Set up pg_hba.conf and pg_ident.conf for the role running
 	# pg_rewind.  This role is used for all the tests, and has
@@ -176,7 +176,7 @@ sub create_standby
 	my $extra_name = shift;
 
 	$node_standby =
-	  get_new_node('standby' . ($extra_name ? "_${extra_name}" : ''));
+	  PostgresNode->new('standby' . ($extra_name ? "_${extra_name}" : ''));
 	$node_primary->backup('my_backup');
 	$node_standby->init_from_backup($node_primary, 'my_backup');
 	my $connstr_primary = $node_primary->connstr();

src/bin/pg_verifybackup/t/002_algorithm.pl

@@ -12,7 +12,7 @@
 use TestLib;
 use Test::More tests => 19;
 
-my $primary = get_new_node('primary');
+my $primary = PostgresNode->new('primary');
 $primary->init(allows_streaming => 1);
 $primary->start;
 

src/bin/pg_verifybackup/t/003_corruption.pl

@@ -12,7 +12,7 @@
 use TestLib;
 use Test::More tests => 44;
 
-my $primary = get_new_node('primary');
+my $primary = PostgresNode->new('primary');
 $primary->init(allows_streaming => 1);
 $primary->start;
 

src/bin/pg_verifybackup/t/004_options.pl

@@ -13,7 +13,7 @@
 use Test::More tests => 25;
 
 # Start up the server and take a backup.
-my $primary = get_new_node('primary');
+my $primary = PostgresNode->new('primary');
 $primary->init(allows_streaming => 1);
 $primary->start;
 my $backup_path = $primary->backup_dir . '/test_options';

src/bin/pg_verifybackup/t/006_encoding.pl

@@ -11,7 +11,7 @@
 use TestLib;
 use Test::More tests => 5;
 
-my $primary = get_new_node('primary');
+my $primary = PostgresNode->new('primary');
 $primary->init(allows_streaming => 1);
 $primary->start;
 my $backup_path = $primary->backup_dir . '/test_encoding';

src/bin/pg_verifybackup/t/007_wal.pl

@@ -13,7 +13,7 @@
 use Test::More tests => 7;
 
 # Start up the server and take a backup.
-my $primary = get_new_node('primary');
+my $primary = PostgresNode->new('primary');
 $primary->init(allows_streaming => 1);
 $primary->start;
 my $backup_path = $primary->backup_dir . '/test_wal';

src/bin/pgbench/t/001_pgbench_with_server.pl

@@ -10,7 +10,7 @@
 use Config;
 
 # start a pgbench specific server
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 $node->start;
 

src/bin/psql/t/010_tab_completion.pl

@@ -34,7 +34,7 @@
 }
 
 # start a new server
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 $node->start;
 

src/bin/scripts/t/010_clusterdb.pl

@@ -12,7 +12,7 @@
 program_version_ok('clusterdb');
 program_options_handling_ok('clusterdb');
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 $node->start;
 

src/bin/scripts/t/011_clusterdb_all.pl

@@ -8,7 +8,7 @@
 use TestLib;
 use Test::More tests => 2;
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 $node->start;
 

src/bin/scripts/t/020_createdb.pl

@@ -12,7 +12,7 @@
 program_version_ok('createdb');
 program_options_handling_ok('createdb');
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 $node->start;
 

src/bin/scripts/t/040_createuser.pl

@@ -12,7 +12,7 @@
 program_version_ok('createuser');
 program_options_handling_ok('createuser');
 
-my $node = get_new_node('main');
+my $node = PostgresNode->new('main');
 $node->init;
 $node->start;