Skip to content

Commit 1fc698c

Browse files
committed
Suppress parallel build in interfaces/ecpg/preproc/.
This is to see if it will stop intermittent build failures on buildfarm member okapi. We know that gmake 3.82 has some problems with sometimes not honoring dependencies in parallel builds, and it seems likely that this is more of the same. Since the vast bulk of the work in the preproc directory is associated with creating preproc.c and then preproc.o, parallelism buys us hardly anything here anyway. Also, make both this .NOTPARALLEL and the one previously added in interfaces/ecpg/Makefile be conditional on "ifeq ($(MAKE_VERSION),3.82)". The known bug in gmake is fixed upstream and should not be present in 3.83 and up, and there's no reason to think it affects older releases.
1 parent 3c84046 commit 1fc698c

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/interfaces/ecpg/Makefile

+2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ SUBDIRS = include pgtypeslib ecpglib compatlib preproc
1010
# (There are some other parallelism bugs in the subdirectory makefiles
1111
# themselves, but there's little point in fixing them as long as we have
1212
# to use this big hammer.)
13+
ifeq ($(MAKE_VERSION),3.82)
1314
.NOTPARALLEL:
15+
endif
1416

1517
$(recurse)
1618

src/interfaces/ecpg/preproc/Makefile

+6
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@ OBJS= preproc.o type.o ecpg.o output.o parser.o \
3030
keywords.o c_keywords.o ecpg_keywords.o kwlookup.o ../ecpglib/typename.o descriptor.o variable.o \
3131
$(WIN32RES)
3232

33+
# Suppress parallel build to avoid a bug in gmake 3.82
34+
# (see comments in ../Makefile)
35+
ifeq ($(MAKE_VERSION),3.82)
36+
.NOTPARALLEL:
37+
endif
38+
3339
all: ecpg
3440

3541
ecpg: $(OBJS) | submake-libpgport

0 commit comments

Comments
 (0)