Skip to content

Commit 112b006

Browse files
committed
logical decoding: Remove TODO about unnecessary optimization.
Measurements show, and intuition agrees, that there's currently no known cases where adding a fastpath to avoid allocating / ordering a heap for a single transaction is worthwhile. Author: Dilip Kumar Discussion: https://postgr.es/m/CAFiTN-sp701wvzvnLQJGk7JDqrFM8f--97-ihbwkU8qvn=p8nw@mail.gmail.com
1 parent f15ace7 commit 112b006

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/backend/replication/logical/reorderbuffer.c

-5
Original file line numberDiff line numberDiff line change
@@ -1037,11 +1037,6 @@ ReorderBufferIterTXNInit(ReorderBuffer *rb, ReorderBufferTXN *txn,
10371037
nr_txns++;
10381038
}
10391039

1040-
/*
1041-
* TODO: Consider adding fastpath for the rather common nr_txns=1 case, no
1042-
* need to allocate/build a heap then.
1043-
*/
1044-
10451040
/* allocate iteration state */
10461041
state = (ReorderBufferIterTXNState *)
10471042
MemoryContextAllocZero(rb->context,

0 commit comments

Comments
 (0)