Don't allow both --source-server and --source-target args to pg_rewind.

hlinnaka · hlinnaka · commit 0d4d7d61850f · 2016-10-07T14:35:17.000+03:00
They are supposed to be mutually exclusive, but there was no check for
that.

Michael Banck

Discussion: &lt;20161007103414.GD12247@nighthawk.caipicrew.dd-dns.de&gt;
diff --git a/src/bin/pg_rewind/pg_rewind.c b/src/bin/pg_rewind/pg_rewind.c
@@ -162,6 +162,13 @@ main(int argc, char **argv)
 		exit(1);
 	}
 
+	if (datadir_source != NULL && connstr_source != NULL)
+	{
+		fprintf(stderr, _("%s: only one of --source-pgdata or --source-server can be specified\n"), progname);
+		fprintf(stderr, _("Try \"%s --help\" for more information.\n"), progname);
+		exit(1);
+	}
+
 	if (datadir_target == NULL)
 	{
 		fprintf(stderr, _("%s: no target data directory specified (--target-pgdata)\n"), progname);

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,13 @@ main(int argc, char **argv)`
`162`	`162`	`exit(1);`
`163`	`163`	`}`
`164`	`164`
	`165`	`+ if (datadir_source != NULL && connstr_source != NULL)`
	`166`	`+ {`
	`167`	`+ fprintf(stderr, _("%s: only one of --source-pgdata or --source-server can be specified\n"), progname);`
	`168`	`+ fprintf(stderr, _("Try \"%s --help\" for more information.\n"), progname);`
	`169`	`+ exit(1);`
	`170`	`+ }`
	`171`	`+`
`165`	`172`	`if (datadir_target == NULL)`
`166`	`173`	`{`
`167`	`174`	`fprintf(stderr, _("%s: no target data directory specified (--target-pgdata)\n"), progname);`