Skip to content

Commit 089da3c

Browse files
committed
doc: Apply more consistently <productname> markup for OpenSSL
OpenSSL was quoted in inconsistent ways in many places of the docs, sometimes with <application>, <productname> or just nothing. Author: Daniel Gustafsson Discussion: https://postgr.es/m/[email protected]
1 parent 7307df1 commit 089da3c

File tree

5 files changed

+49
-38
lines changed

5 files changed

+49
-38
lines changed

doc/src/sgml/config.sgml

+9-7
Original file line numberDiff line numberDiff line change
@@ -1261,10 +1261,11 @@ include_dir 'conf.d'
12611261
<term><literal>+3DES</literal></term>
12621262
<listitem>
12631263
<para>
1264-
The OpenSSL default order for <literal>HIGH</literal> is problematic
1265-
because it orders 3DES higher than AES128. This is wrong because
1266-
3DES offers less security than AES128, and it is also much
1267-
slower. <literal>+3DES</literal> reorders it after all other
1264+
The <productname>OpenSSL</productname> default order for
1265+
<literal>HIGH</literal> is problematic because it orders 3DES
1266+
higher than AES128. This is wrong because 3DES offers less
1267+
security than AES128, and it is also much slower.
1268+
<literal>+3DES</literal> reorders it after all other
12681269
<literal>HIGH</literal> and <literal>MEDIUM</literal> ciphers.
12691270
</para>
12701271
</listitem>
@@ -1284,8 +1285,8 @@ include_dir 'conf.d'
12841285
</para>
12851286

12861287
<para>
1287-
Available cipher suite details will vary across OpenSSL versions. Use
1288-
the command
1288+
Available cipher suite details will vary across
1289+
<productname>OpenSSL</productname> versions. Use the command
12891290
<literal>openssl ciphers -v 'HIGH:MEDIUM:+3DES:!aNULL'</literal> to
12901291
see actual details for the currently installed <application>OpenSSL</application>
12911292
version. Note that this list is filtered at run time based on the
@@ -1337,7 +1338,8 @@ include_dir 'conf.d'
13371338
</para>
13381339

13391340
<para>
1340-
OpenSSL names for the most common curves are:
1341+
<productname>OpenSSL</productname> names for the most common curves
1342+
are:
13411343
<literal>prime256v1</literal> (NIST P-256),
13421344
<literal>secp384r1</literal> (NIST P-384),
13431345
<literal>secp521r1</literal> (NIST P-521).

doc/src/sgml/installation.sgml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2293,7 +2293,7 @@ ERROR: could not load library "/opt/dbs/pgsql/lib/plperl.so": Bad address
22932293

22942294
<listitem>
22952295
<para>
2296-
OpenSSL is not supported.
2296+
<productname>OpenSSL</productname> is not supported.
22972297
</para>
22982298
</listitem>
22992299

doc/src/sgml/libpq.sgml

+29-22
Original file line numberDiff line numberDiff line change
@@ -812,7 +812,8 @@ int callback_fn(char *buf, int size, PGconn *conn);
812812
its path will be in <literal>conn->sslkey</literal> when the callback
813813
is invoked. This will be empty if the default key path is being used.
814814
For keys that are engine specifiers, it is up to engine implementations
815-
whether they use the OpenSSL password callback or define their own handling.
815+
whether they use the <productname>OpenSSL</productname> password
816+
callback or define their own handling.
816817
</para>
817818

818819
<para>
@@ -1672,13 +1673,15 @@ postgresql://%2Fvar%2Flib%2Fpostgresql/dbname
16721673
<para>
16731674
Specifying this parameter with any non-empty value suppresses the
16741675
<literal>Enter PEM pass phrase:</literal>
1675-
prompt that OpenSSL will emit by default when an encrypted client
1676-
certificate key is provided to <literal>libpq</literal>.
1676+
prompt that <productname>OpenSSL</productname> will emit by default
1677+
when an encrypted client certificate key is provided to
1678+
<literal>libpq</literal>.
16771679
</para>
16781680
<para>
1679-
If the key is not encrypted this parameter is ignored. The parameter has no
1680-
effect on keys specified by OpenSSL engines unless the engine uses the
1681-
OpenSSL password callback mechanism for prompts.
1681+
If the key is not encrypted this parameter is ignored. The parameter
1682+
has no effect on keys specified by <productname>OpenSSL</productname>
1683+
engines unless the engine uses the <productname>OpenSSL</productname>
1684+
password callback mechanism for prompts.
16821685
</para>
16831686
<para>
16841687
There is no environment variable equivalent to this option, and no
@@ -2471,8 +2474,9 @@ void *PQsslStruct(const PGconn *conn, const char *struct_name);
24712474
</para>
24722475
<para>
24732476
The struct(s) available depend on the SSL implementation in use.
2474-
For OpenSSL, there is one struct, available under the name "OpenSSL",
2475-
and it returns a pointer to the OpenSSL <literal>SSL</literal> struct.
2477+
For <productname>OpenSSL</productname>, there is one struct,
2478+
available under the name "OpenSSL", and it returns a pointer to the
2479+
<productname>OpenSSL</productname> <literal>SSL</literal> struct.
24762480
To use this function, code along the following lines could be used:
24772481
<programlisting><![CDATA[
24782482
#include <libpq-fe.h>
@@ -2516,8 +2520,9 @@ void *PQgetssl(const PGconn *conn);
25162520
<para>
25172521
This function is equivalent to <literal>PQsslStruct(conn, "OpenSSL")</literal>. It should
25182522
not be used in new applications, because the returned struct is
2519-
specific to OpenSSL and will not be available if another SSL
2520-
implementation is used. To check if a connection uses SSL, call
2523+
specific to <productname>OpenSSL</productname> and will not be
2524+
available if another <acronym>SSL</acronym> implementation is used.
2525+
To check if a connection uses SSL, call
25212526
<xref linkend="libpq-PQsslInUse"/> instead, and for more details about the
25222527
connection, use <xref linkend="libpq-PQsslAttribute"/>.
25232528
</para>
@@ -7665,15 +7670,17 @@ ldap://ldap.acme.com/cn=dbserver,cn=hosts?pgconnectinfo?base?(objectclass=*)
76657670

76667671
<para>
76677672
The key may be
7668-
stored in cleartext or encrypted with a passphrase using any algorithm supported
7669-
by OpenSSL, like AES-128. If the key is stored encrypted, then the passphrase
7670-
may be provided in the <xref linkend="libpq-connect-sslpassword"/> connection
7671-
option. If an encrypted key is supplied and the <literal>sslpassword</literal>
7672-
option is absent or blank, a password will be prompted for interactively by
7673-
OpenSSL with a <literal>Enter PEM pass phrase:</literal>
7674-
prompt if a TTY is available. Applications can override the client certificate
7675-
prompt and the handling of the <literal>sslpassword</literal> parameter by supplying
7676-
their own key password callback; see
7673+
stored in cleartext or encrypted with a passphrase using any algorithm
7674+
supported by <productname>OpenSSL</productname>, like AES-128. If the key
7675+
is stored encrypted, then the passphrase may be provided in the
7676+
<xref linkend="libpq-connect-sslpassword"/> connection option. If an
7677+
encrypted key is supplied and the <literal>sslpassword</literal> option
7678+
is absent or blank, a password will be prompted for interactively by
7679+
<productname>OpenSSL</productname> with a
7680+
<literal>Enter PEM pass phrase:</literal> prompt if a TTY is available.
7681+
Applications can override the client certificate prompt and the handling
7682+
of the <literal>sslpassword</literal> parameter by supplying their own
7683+
key password callback; see
76777684
<xref linkend="libpq-pqsetsslkeypasshook-openssl"/>.
76787685
</para>
76797686

@@ -7936,7 +7943,7 @@ void PQinitOpenSSL(int do_ssl, int do_crypto);
79367943

79377944
<para>
79387945
When <parameter>do_ssl</parameter> is non-zero, <application>libpq</application>
7939-
will initialize the <application>OpenSSL</application> library before first
7946+
will initialize the <productname>OpenSSL</productname> library before first
79407947
opening a database connection. When <parameter>do_crypto</parameter> is
79417948
non-zero, the <literal>libcrypto</literal> library will be initialized. By
79427949
default (if <xref linkend="libpq-PQinitOpenSSL"/> is not called), both libraries
@@ -7945,7 +7952,7 @@ void PQinitOpenSSL(int do_ssl, int do_crypto);
79457952
</para>
79467953

79477954
<para>
7948-
If your application uses and initializes either <application>OpenSSL</application>
7955+
If your application uses and initializes either <productname>OpenSSL</productname>
79497956
or its underlying <literal>libcrypto</literal> library, you <emphasis>must</emphasis>
79507957
call this function with zeroes for the appropriate parameter(s)
79517958
before first opening a database connection. Also be sure that you
@@ -7967,7 +7974,7 @@ void PQinitSSL(int do_ssl);
79677974
This function is equivalent to
79687975
<literal>PQinitOpenSSL(do_ssl, do_ssl)</literal>.
79697976
It is sufficient for applications that initialize both or neither
7970-
of <application>OpenSSL</application> and <literal>libcrypto</literal>.
7977+
of <productname>OpenSSL</productname> and <literal>libcrypto</literal>.
79717978
</para>
79727979

79737980
<para>

doc/src/sgml/pgcrypto.sgml

+8-6
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ digest(data bytea, type text) returns bytea
4545
<literal>sha224</literal>, <literal>sha256</literal>,
4646
<literal>sha384</literal> and <literal>sha512</literal>.
4747
If <filename>pgcrypto</filename> was built with
48-
OpenSSL, more algorithms are available, as detailed in
49-
<xref linkend="pgcrypto-with-without-openssl"/>.
48+
<productname>OpenSSL</productname>, more algorithms are available, as
49+
detailed in <xref linkend="pgcrypto-with-without-openssl"/>.
5050
</para>
5151

5252
<para>
@@ -1162,9 +1162,10 @@ gen_random_uuid() returns uuid
11621162
</para>
11631163

11641164
<para>
1165-
When compiled with OpenSSL, there will be more algorithms available.
1166-
Also public-key encryption functions will be faster as OpenSSL
1167-
has more optimized BIGNUM functions.
1165+
When compiled with <productname>OpenSSL</productname>, there will be
1166+
more algorithms available. Also public-key encryption functions will
1167+
be faster as <productname>OpenSSL</productname> has more optimized
1168+
BIGNUM functions.
11681169
</para>
11691170

11701171
<table id="pgcrypto-with-without-openssl">
@@ -1239,7 +1240,8 @@ gen_random_uuid() returns uuid
12391240
<orderedlist>
12401241
<listitem>
12411242
<para>
1242-
Any digest algorithm OpenSSL supports is automatically picked up.
1243+
Any digest algorithm <productname>OpenSSL</productname> supports
1244+
is automatically picked up.
12431245
This is not possible with ciphers, which need to be supported
12441246
explicitly.
12451247
</para>

doc/src/sgml/sslinfo.sgml

+2-2
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,8 @@
173173
<para>
174174
This function returns the value of the specified field in the
175175
certificate subject, or NULL if the field is not present.
176-
Field names are string constants that are
177-
converted into ASN1 object identifiers using the OpenSSL object
176+
Field names are string constants that are converted into ASN1 object
177+
identifiers using the <productname>OpenSSL</productname> object
178178
database. The following values are acceptable:
179179
</para>
180180
<literallayout class="monospaced">

0 commit comments

Comments
 (0)