Skip to content

Commit 078c9cd

Browse files
committed
Fix comment in xlogutils.c
The existing callers of XLogReadDetermineTimeline() performing recovery need to check a replay LSN position when determining on which timeline to read a WAL page. A portion of the comment describing this function said exactly that, while referring to a routine for fetching a write LSN, something not available in recovery. Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/[email protected]
1 parent 81ec990 commit 078c9cd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/backend/access/transam/xlogutils.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -681,10 +681,10 @@ XLogTruncateRelation(RelFileNode rnode, ForkNumber forkNum,
681681
* copied to a new timeline.
682682
*
683683
* The caller must also make sure it doesn't read past the current replay
684-
* position (using GetWalRcvWriteRecPtr) if executing in recovery, so it
684+
* position (using GetXLogReplayRecPtr) if executing in recovery, so it
685685
* doesn't fail to notice that the current timeline became historical. The
686686
* caller must also update ThisTimeLineID with the result of
687-
* GetWalRcvWriteRecPtr and must check RecoveryInProgress().
687+
* GetXLogReplayRecPtr and must check RecoveryInProgress().
688688
*/
689689
void
690690
XLogReadDetermineTimeline(XLogReaderState *state, XLogRecPtr wantPage, uint32 wantLength)

0 commit comments

Comments
 (0)