Skip to content

incremental restore and missing pg_control #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gsmolk opened this issue Jan 26, 2021 · 1 comment
Closed

incremental restore and missing pg_control #304

gsmolk opened this issue Jan 26, 2021 · 1 comment
Labels
enhancement test-case

Comments

@gsmolk
Copy link
Contributor

gsmolk commented Jan 26, 2021

Currently it plays this way:

INFO: Running incremental restore into nonempty directory: "/tmp/restore"
ERROR: Could not open file "/tmp/restore/global/pg_control" for reading: No such file or directory

We should just go with "--force"
@gsmolk gsmolk modified the milestones: 2.4.10, 2.4.11 Jan 26, 2021
@gsmolk gsmolk modified the milestones: 2.4.11, 2.4.12 Feb 16, 2021
@kulaginm kulaginm modified the milestones: 2.4.18, 2.5.3 Oct 15, 2021
@kulaginm kulaginm modified the milestones: 2.5.4, 2.5.5 Dec 22, 2021
@kulaginm kulaginm modified the milestones: 2.5.5, 2.5.6 Feb 16, 2022
@kulaginm kulaginm modified the milestones: 2.5.6, 2.5.7 May 26, 2022
@MetalDream666 MetalDream666 modified the milestones: 2.5.7, 2.5.8 Jun 1, 2022
@Burus Burus added the test-case label Jun 9, 2022
@Burus Burus removed this from the 2.5.8 milestone Sep 14, 2022
funny-falcon pushed a commit that referenced this issue Dec 26, 2023
[PBCKP-218] Incremental restore and missing pg_control (issue #304)
52e47fe 
- pg_control file backup after all other files in backup
- pg_control file restore last in full restore
- rename pg_control to pg_control.pbk.bak at start of non-full restore
- remove pg_control.pbk.bak in the end of successfull non-full restore
- use pg_control.pbk.bak after failed non-full restore
- added tests for full and incremental restore

Tags: backup, catchup, restore
@funny-falcon
Copy link
Collaborator

Issue with pg_control probably fixed in 52e47fe , so there's no need in --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement test-case
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Burus @funny-falcon @gsmolk @kulaginm @MetalDream666