Skip to content

Commit 192df76

Browse files
committed
- simplify code by using OPENBASEDIR_CHECKPATH
1 parent 8dfe438 commit 192df76

File tree

1 file changed

+5
-25
lines changed

1 file changed

+5
-25
lines changed

ext/standard/link_win32.c

+5-25
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,7 @@ PHP_FUNCTION(readlink)
8282
return;
8383
}
8484

85-
if (PG(safe_mode) && !php_checkuid(link, NULL, CHECKUID_CHECK_FILE_AND_DIR)) {
86-
RETURN_FALSE;
87-
}
88-
89-
if (php_check_open_basedir(link TSRMLS_CC)) {
85+
if (OPENBASEDIR_CHECKPATH(link)) {
9086
RETURN_FALSE;
9187
}
9288

@@ -194,19 +190,11 @@ PHP_FUNCTION(symlink)
194190
RETURN_FALSE;
195191
}
196192

197-
if (PG(safe_mode) && !php_checkuid(dest_p, NULL, CHECKUID_CHECK_FILE_AND_DIR)) {
198-
RETURN_FALSE;
199-
}
200-
201-
if (PG(safe_mode) && !php_checkuid(source_p, NULL, CHECKUID_CHECK_FILE_AND_DIR)) {
193+
if (OPENBASEDIR_CHECKPATH(dest_p)) {
202194
RETURN_FALSE;
203195
}
204196

205-
if (php_check_open_basedir(dest_p TSRMLS_CC)) {
206-
RETURN_FALSE;
207-
}
208-
209-
if (php_check_open_basedir(source_p TSRMLS_CC)) {
197+
if (OPENBASEDIR_CHECKPATH(source_p)) {
210198
RETURN_FALSE;
211199
}
212200

@@ -255,19 +243,11 @@ PHP_FUNCTION(link)
255243
RETURN_FALSE;
256244
}
257245

258-
if (PG(safe_mode) && !php_checkuid(dest_p, NULL, CHECKUID_CHECK_FILE_AND_DIR)) {
259-
RETURN_FALSE;
260-
}
261-
262-
if (PG(safe_mode) && !php_checkuid(source_p, NULL, CHECKUID_CHECK_FILE_AND_DIR)) {
263-
RETURN_FALSE;
264-
}
265-
266-
if (php_check_open_basedir(dest_p TSRMLS_CC)) {
246+
if (OPENBASEDIR_CHECKPATH(source_p)) {
267247
RETURN_FALSE;
268248
}
269249

270-
if (php_check_open_basedir(source_p TSRMLS_CC)) {
250+
if (OPENBASEDIR_CHECKPATH(dest_p)) {
271251
RETURN_FALSE;
272252
}
273253

0 commit comments

Comments
 (0)