Fix unrelated test failure and apply suggestion from code review

Author: kocsismate

ext/zend_test/test.c

@@ -38,6 +38,7 @@ static zend_class_entry *zend_test_class;
 static zend_class_entry *zend_test_child_class;
 static zend_class_entry *zend_test_trait;
 static zend_class_entry *zend_test_attribute;
+static zend_class_entry *zend_test_repeatable_attribute;
 static zend_class_entry *zend_test_parameter_attribute;
 static zend_class_entry *zend_test_property_attribute;
 static zend_class_entry *zend_test_class_with_method_with_parameter_attribute;
@@ -684,6 +685,9 @@ PHP_MINIT_FUNCTION(zend_test)
 		attr->validator = zend_attribute_validate_zendtestattribute;
 	}
 
+	zend_test_repeatable_attribute = register_class_ZendTestRepeatableAttribute();
+	zend_mark_internal_attribute(zend_test_repeatable_attribute);
+
 	zend_test_parameter_attribute = register_class_ZendTestParameterAttribute();
 	zend_mark_internal_attribute(zend_test_parameter_attribute);
 

ext/zend_test/test.stub.php

@@ -49,22 +49,25 @@ public function returnsThrowable(): Exception {}
 
     trait _ZendTestTrait {
         /** @var int */
-        #[ZendTestAttribute]
-        #[ZendTestAttribute]
+        #[ZendTestRepeatableAttribute]
+        #[ZendTestRepeatableAttribute]
         public const TEST_CONST = 1;
 
         /** @var mixed */
-        #[ZendTestAttribute]
+        #[ZendTestRepeatableAttribute]
         #[ZendTestPropertyAttribute("testProp")]
         public $testProp;
 
         #[ZendTestAttribute]
         public function testMethod(): bool {}
     }
 
-    #[Attribute(Attribute::TARGET_ALL|Attribute::IS_REPEATABLE)]
+    #[Attribute(Attribute::TARGET_ALL)]
     final class ZendTestAttribute {
+    }
 
+    #[Attribute(Attribute::TARGET_ALL|Attribute::IS_REPEATABLE)]
+    final class ZendTestRepeatableAttribute {
     }
 
     #[Attribute(Attribute::TARGET_PARAMETER)]

ext/zend_test/test_arginfo.h

@@ -11,6 +11,7 @@ class Foo {
 
 $reflectionConstant = new ReflectionClassConstant(Foo::class, "TEST_CONST");
 var_dump($reflectionConstant->getAttributes()[0]->newInstance());
+var_dump($reflectionConstant->getAttributes()[1]->newInstance());
 
 $reflectionProperty = new ReflectionProperty(Foo::class, "testProp");
 var_dump($reflectionProperty->getAttributes()[0]->newInstance());
@@ -21,9 +22,11 @@ var_dump($reflectionMethod->getAttributes()[0]->newInstance());
 
 ?>
 --EXPECTF--
-object(ZendTestAttribute)#%d (%d) {
+object(ZendTestRepeatableAttribute)#%d (%d) {
 }
-object(ZendTestAttribute)#%d (%d) {
+object(ZendTestRepeatableAttribute)#%d (%d) {
+}
+object(ZendTestRepeatableAttribute)#%d (%d) {
 }
 object(ZendTestPropertyAttribute)#%d (%d) {
   ["parameter"]=>