Skip to content

Commit 3a8c8fd

Browse files
committed
disable stuff not available for 7 yet
1 parent 545e34b commit 3a8c8fd

File tree

4 files changed

+15
-12
lines changed

4 files changed

+15
-12
lines changed

.travis/travis.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,11 @@ function run_memcached_tests() {
155155

156156
pushd "${PHP_MEMCACHED_BUILD_DIR}/memcached-${PHP_MEMCACHED_VERSION}"
157157
# We have one xfail test, we run it separately
158-
php run-tests.php -d extension=msgpack.so -d extension=igbinary.so -d extension=memcached.so -n ./tests/expire.phpt
158+
php run-tests.php -d extension=memcached.so -n ./tests/expire.phpt
159159
rm ./tests/expire.phpt
160160

161161
# Run normal tests
162-
php run-tests.php -d extension=msgpack.so -d extension=igbinary.so -d extension=memcached.so -n ./tests/*.phpt
162+
php run-tests.php -d extension=memcached.so -n ./tests/*.phpt
163163
retval=$?
164164
for i in `ls tests/*.out 2>/dev/null`; do
165165
echo "-- START ${i}";
@@ -213,14 +213,14 @@ case $ACTION in
213213
install_libmemcached
214214

215215
# Install igbinary extension
216-
install_igbinary
216+
# install_igbinary
217217

218218
# install msgpack
219-
install_msgpack
219+
# install_msgpack
220220

221221
# install SASL
222222
if test "x$ENABLE_SASL" = "xyes"; then
223-
install_sasl
223+
# install_sasl
224224
fi
225225
;;
226226

php_memcached.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ static PHP_METHOD(Memcached, __construct)
406406
zend_fcall_info fci = {0};
407407
zend_fcall_info_cache fci_cache;
408408

409-
if (zend_parse_parameters_throw(ZEND_NUM_ARGS(), "|S!f!S", &persistent_id, &fci, &fci_cache, &conn_str) == FAILURE) {
409+
if (zend_parse_parameters(ZEND_NUM_ARGS(), "|S!f!S", &persistent_id, &fci, &fci_cache, &conn_str) == FAILURE) {
410410
return;
411411
}
412412

tests/bad_construct.phpt

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Memcached construct with bad arguments
44
<?php if (!extension_loaded("memcached")) print "skip"; ?>
55
--FILE--
66
<?php
7-
error_reporting(0);
7+
88
$m = new Memcached((object)array());
99
echo $php_errormsg, "\n";
1010
var_dump($m);
@@ -21,9 +21,12 @@ var_dump ($extended->setOption (Memcached::OPT_BINARY_PROTOCOL, true));
2121
echo "OK" . PHP_EOL;
2222

2323
--EXPECTF--
24-
Memcached::__construct() expects parameter %s
25-
NULL
24+
Warning: Memcached::__construct() expects parameter 1 to be string, object given in %s on line 3
25+
Memcached::__construct() expects parameter 1 to be string, object given
26+
object(Memcached)#1 (0) {
27+
}
2628

27-
Warning: Memcached::setOption(): Memcached constructor was not called in %s on line %d
29+
Warning: Memcached::setOption(): Memcached constructor was not called in %s on line 14
2830
NULL
29-
OK
31+
OK
32+

tests/experimental/get_bykey_cas.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ string(4) "asdf"
5959
float(%d)
6060
SUCCESS
6161
bool(false)
62-
NULL
62+
float(0)
6363
NOT FOUND
6464
bool(false)
6565
NULL

0 commit comments

Comments
 (0)