Skip to content

Commit 6513ca8

Browse files
committed
Merge branch 'PHP-5.3' into PHP-5.4
* PHP-5.3: - Value stored to var is never read
2 parents 8693bae + dc1138b commit 6513ca8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: ext/dom/element.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -832,7 +832,7 @@ PHP_FUNCTION(dom_element_set_attribute_ns)
832832
}
833833

834834
if (errorcode == 0 && is_xmlns == 0) {
835-
attr = xmlSetNsProp(elemp, nsptr, (xmlChar *)localname, (xmlChar *)value);
835+
xmlSetNsProp(elemp, nsptr, (xmlChar *)localname, (xmlChar *)value);
836836
}
837837
} else {
838838
name_valid = xmlValidateName((xmlChar *) localname, 0);
@@ -844,7 +844,7 @@ PHP_FUNCTION(dom_element_set_attribute_ns)
844844
if (attr != NULL && attr->type != XML_ATTRIBUTE_DECL) {
845845
node_list_unlink(attr->children TSRMLS_CC);
846846
}
847-
attr = xmlSetProp(elemp, (xmlChar *)localname, (xmlChar *)value);
847+
xmlSetProp(elemp, (xmlChar *)localname, (xmlChar *)value);
848848
}
849849
}
850850
}

0 commit comments

Comments
 (0)