Skip to content

Commit 088905b

Browse files
committed
Merge branch 'PHP-7.0' into PHP-7.1
* PHP-7.0: Fixed bug #72668 (Spurious warning when exception is thrown in user defined function)
2 parents 0d50502 + f5e56cf commit 088905b

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

ext/sqlite3/sqlite3.c

+3-1
Original file line numberDiff line numberDiff line change
@@ -660,8 +660,10 @@ PHP_METHOD(sqlite3, querySingle)
660660
break;
661661
}
662662
default:
663+
if (!EG(exception)) {
663664
php_sqlite3_error(db_obj, "Unable to execute statement: %s", sqlite3_errmsg(db_obj->db));
664-
RETVAL_FALSE;
665+
}
666+
RETVAL_FALSE;
665667
}
666668
sqlite3_finalize(stmt);
667669
}

ext/sqlite3/tests/bug72668.phpt

+24
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
--TEST--
2+
Bug #72668 (Spurious warning when exception is thrown in user defined function)
3+
--SKIPIF--
4+
<?php
5+
if (!extension_loaded('sqlite3')) die('skip'); ?>
6+
--FILE--
7+
<?php
8+
function my_udf_md5($string) {
9+
throw new \Exception("test exception\n");
10+
}
11+
12+
$db = new SQLite3(':memory:');
13+
$db->createFunction('my_udf_md5', 'my_udf_md5');
14+
15+
try {
16+
$result = $db->querySingle('SELECT my_udf_md5("test")');
17+
var_dump($result);
18+
}
19+
catch(\Exception $e) {
20+
echo "Exception: ".$e->getMessage();
21+
}
22+
?>
23+
--EXPECT--
24+
Exception: test exception

0 commit comments

Comments
 (0)