Fix double free of DSN credentials

Author: nikic

ext/pdo_dblib/dblib_driver.c

@@ -522,7 +522,7 @@ static int pdo_dblib_handle_factory(pdo_dbh_t *dbh, zval *driver_options)
 	}
 
 	if (!dbh->username && vars[6].optval) {
-		dbh->username = vars[6].optval;
+		dbh->username = pestrdup(vars[6].optval, dbh->is_persistent);
 	}
 
 	if (dbh->username) {
@@ -532,7 +532,7 @@ static int pdo_dblib_handle_factory(pdo_dbh_t *dbh, zval *driver_options)
 	}
 
 	if (!dbh->password && vars[7].optval) {
-		dbh->password = vars[7].optval;
+		dbh->password = pestrdrup(vars[7].optval, dbh->is_persistent);
 	}
 
 	if (dbh->password) {

ext/pdo_firebird/firebird_driver.c

@@ -635,11 +635,11 @@ static int pdo_firebird_handle_factory(pdo_dbh_t *dbh, zval *driver_options) /*
 	php_pdo_parse_data_source(dbh->data_source, dbh->data_source_len, vars, 5);
 
 	if (!dbh->username && vars[3].optval) {
-		dbh->username = vars[3].optval;
+		dbh->username = pestrdup(vars[3].optval, dbh->is_persistent);
 	}
 
 	if (!dbh->password && vars[4].optval) {
-		dbh->password = vars[4].optval;
+		dbh->password = pestrdup(vars[4].optval, dbh->is_persistent);
 	}
 
 	do {

ext/pdo_mysql/mysql_driver.c

@@ -811,11 +811,11 @@ static int pdo_mysql_handle_factory(pdo_dbh_t *dbh, zval *driver_options)
 	}
 
 	if (!dbh->username && vars[5].optval) {
-		dbh->username = vars[5].optval;
+		dbh->username = pestrdup(vars[5].optval, dbh->is_persistent);
 	}
 
 	if (!dbh->password && vars[6].optval) {
-		dbh->password = vars[6].optval;
+		dbh->password = pestrdup(vars[6].optval, dbh->is_persistent);
 	}
 
 	/* TODO: - Check zval cache + ZTS */

ext/pdo_oci/oci_driver.c

@@ -748,7 +748,7 @@ static int pdo_oci_handle_factory(pdo_dbh_t *dbh, zval *driver_options) /* {{{ *
 
 	/* username */
 	if (!dbh->username && vars[2].optval) {
-		dbh->username = vars[2].optval;
+		dbh->username = pestrdup(vars[2].optval, dbh->is_persistent);
 	}
 
 	if (dbh->username) {
@@ -763,7 +763,7 @@ static int pdo_oci_handle_factory(pdo_dbh_t *dbh, zval *driver_options) /* {{{ *
 
 	/* password */
 	if (!dbh->password && vars[3].optval) {
-		dbh->password = vars[3].optval;
+		dbh->password = pestrdup(vars[3].optval, dbh->is_persistent);
 	}
 
 	if (dbh->password) {