Skip to content

Commit 03263fd

Browse files
committed
get rid of win32_ prefix
1 parent fb1f476 commit 03263fd

File tree

1 file changed

+29
-28
lines changed

1 file changed

+29
-28
lines changed

sapi/cgi/cgi_main.c

+29-28
Original file line numberDiff line numberDiff line change
@@ -225,10 +225,10 @@ static php_cgi_globals_struct php_cgi_globals;
225225

226226
#ifdef PHP_WIN32
227227
#define WIN32_MAX_SPAWN_CHILDREN 64
228-
HANDLE win32_kid_cgi_ps[WIN32_MAX_SPAWN_CHILDREN];
229-
int win32_kids;
230-
HANDLE win32_job = NULL;
231-
JOBOBJECT_EXTENDED_LIMIT_INFORMATION win32_ji = { 0 };
228+
HANDLE kid_cgi_ps[WIN32_MAX_SPAWN_CHILDREN];
229+
int kids;
230+
HANDLE job = NULL;
231+
JOBOBJECT_EXTENDED_LIMIT_INFORMATION job_info = { 0 };
232232
#endif
233233

234234
#ifndef HAVE_ATTRIBUTE_WEAK
@@ -1439,20 +1439,20 @@ void fastcgi_cleanup(int signal)
14391439
#else
14401440
BOOL fastcgi_cleanup(DWORD sig)
14411441
{
1442-
int i = win32_kids;
1442+
int i = kids;
14431443

14441444
while (0 < i--) {
1445-
if (NULL == win32_kid_cgi_ps[i]) {
1445+
if (NULL == kid_cgi_ps[i]) {
14461446
continue;
14471447
}
14481448

1449-
TerminateProcess(win32_kid_cgi_ps[i], 0);
1450-
CloseHandle(win32_kid_cgi_ps[i]);
1451-
win32_kid_cgi_ps[i] = NULL;
1449+
TerminateProcess(kid_cgi_ps[i], 0);
1450+
CloseHandle(kid_cgi_ps[i]);
1451+
kid_cgi_ps[i] = NULL;
14521452
}
14531453

1454-
if (win32_job) {
1455-
CloseHandle(win32_job);
1454+
if (job) {
1455+
CloseHandle(job);
14561456
}
14571457

14581458
parent = 0;
@@ -2116,8 +2116,8 @@ consult the installation file that came with this distribution, or visit \n\
21162116
char my_name[MAX_PATH] = {0};
21172117
int i;
21182118

2119-
ZeroMemory(&win32_kid_cgi_ps, sizeof(win32_kid_cgi_ps));
2120-
win32_kids = children < WIN32_MAX_SPAWN_CHILDREN ? children : WIN32_MAX_SPAWN_CHILDREN;
2119+
ZeroMemory(&kid_cgi_ps, sizeof(kid_cgi_ps));
2120+
kids = children < WIN32_MAX_SPAWN_CHILDREN ? children : WIN32_MAX_SPAWN_CHILDREN;
21212121

21222122
SetConsoleCtrlHandler(fastcgi_cleanup, TRUE);
21232123

@@ -2126,42 +2126,43 @@ consult the installation file that came with this distribution, or visit \n\
21262126
GetModuleFileName(NULL, my_name, MAX_PATH);
21272127
cmd_line = my_name;
21282128

2129-
win32_job = CreateJobObject(NULL, NULL);
2130-
if (!win32_job) {
2129+
job = CreateJobObject(NULL, NULL);
2130+
if (!job) {
21312131
DWORD err = GetLastError();
21322132
char *err_text = php_win32_error_to_msg(err);
21332133

21342134
fprintf(stderr, "unable to create job object: [0x%08lx]: %s\n", err, err_text);
21352135

21362136
goto parent_out;
21372137
}
2138-
win32_ji.BasicLimitInformation.LimitFlags = JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE;
2139-
if (!SetInformationJobObject(win32_job, JobObjectExtendedLimitInformation, &win32_ji, sizeof(win32_ji))) {
2138+
2139+
job_info.BasicLimitInformation.LimitFlags = JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE;
2140+
if (!SetInformationJobObject(job, JobObjectExtendedLimitInformation, &job_info, sizeof(job_info))) {
21402141
DWORD err = GetLastError();
21412142
char *err_text = php_win32_error_to_msg(err);
21422143

21432144
fprintf(stderr, "unable to configure job object: [0x%08lx]: %s\n", err, err_text);
21442145
}
21452146

21462147
while (parent) {
2147-
i = win32_kids;
2148+
i = kids;
21482149
while (0 < i--) {
21492150
DWORD status;
21502151

2151-
if (NULL != win32_kid_cgi_ps[i]) {
2152-
if(!GetExitCodeProcess(win32_kid_cgi_ps[i], &status) || status != STILL_ACTIVE) {
2153-
CloseHandle(win32_kid_cgi_ps[i]);
2154-
win32_kid_cgi_ps[i] = NULL;
2152+
if (NULL != kid_cgi_ps[i]) {
2153+
if(!GetExitCodeProcess(kid_cgi_ps[i], &status) || status != STILL_ACTIVE) {
2154+
CloseHandle(kid_cgi_ps[i]);
2155+
kid_cgi_ps[i] = NULL;
21552156
}
21562157
}
21572158
}
21582159

2159-
i = win32_kids;
2160+
i = kids;
21602161
while (0 < i--) {
21612162
PROCESS_INFORMATION pi;
21622163
STARTUPINFO si;
21632164

2164-
if (NULL != win32_kid_cgi_ps[i]) {
2165+
if (NULL != kid_cgi_ps[i]) {
21652166
continue;
21662167
}
21672168

@@ -2175,8 +2176,8 @@ consult the installation file that came with this distribution, or visit \n\
21752176
si.hStdError = INVALID_HANDLE_VALUE;
21762177

21772178
if (CreateProcess(NULL, cmd_line, NULL, NULL, TRUE, CREATE_NO_WINDOW, NULL, NULL, &si, &pi)) {
2178-
win32_kid_cgi_ps[i] = pi.hProcess;
2179-
if (!AssignProcessToJobObject(win32_job, pi.hProcess)) {
2179+
kid_cgi_ps[i] = pi.hProcess;
2180+
if (!AssignProcessToJobObject(job, pi.hProcess)) {
21802181
DWORD err = GetLastError();
21812182
char *err_text = php_win32_error_to_msg(err);
21822183

@@ -2187,13 +2188,13 @@ consult the installation file that came with this distribution, or visit \n\
21872188
DWORD err = GetLastError();
21882189
char *err_text = php_win32_error_to_msg(err);
21892190

2190-
win32_kid_cgi_ps[i] = NULL;
2191+
kid_cgi_ps[i] = NULL;
21912192

21922193
fprintf(stderr, "unable to spawn: [0x%08lx]: %s\n", err, err_text);
21932194
}
21942195
}
21952196

2196-
WaitForMultipleObjects(win32_kids, win32_kid_cgi_ps, FALSE, INFINITE);
2197+
WaitForMultipleObjects(kids, kid_cgi_ps, FALSE, INFINITE);
21972198
}
21982199

21992200
snprintf(kid_buf, 16, "%d", children);

0 commit comments

Comments
 (0)