Skip to content

Commit e925078

Browse files
author
Gabor Berkes
committed
Fix macOS GitHub Actions build: add PCRE2_CFLAGS/LDADD/LDFLAGS
Introduced PCRE2_CFLAGS, PCRE2_LDADD, and PCRE2_LDFLAGS in all relevant Makefile.am files to align with the existing PCRE_* variable usage. This change addresses potential issues with linking and configuration for builds on macOS GitHub runners. These modifications aim to resolve the build failure observed exclusively in the macOS environment while maintaining compatibility across other platforms. Testing will confirm if this adjustment corrects the issue.
1 parent 784cf0b commit e925078

File tree

8 files changed

+15
-0
lines changed

8 files changed

+15
-0
lines changed

examples/multithread/Makefile.am

+2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ multithread_LDADD = \
1414
$(MAXMIND_LDADD) \
1515
$(LUA_LDADD) \
1616
$(PCRE_LDADD) \
17+
$(PCRE2_LDADD) \
1718
$(SSDEEP_LDADD) \
1819
$(YAJL_LDADD)
1920

@@ -46,6 +47,7 @@ multithread_CPPFLAGS = \
4647
$(LMDB_CFLAGS) \
4748
$(LUA_CFLAGS) \
4849
$(PCRE_CFLAGS) \
50+
$(PCRE2_CFLAGS) \
4951
$(LIBXML2_CFLAGS)
5052

5153

examples/reading_logs_via_rule_message/Makefile.am

+2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ simple_request_LDADD = \
1414
$(MAXMIND_LDADD) \
1515
$(LUA_LDADD) \
1616
$(PCRE_LDADD) \
17+
$(PCRE2_LDADD) \
1718
$(SSDEEP_LDADD) \
1819
$(YAJL_LDADD)
1920

@@ -46,6 +47,7 @@ simple_request_CPPFLAGS = \
4647
$(LMDB_CFLAGS) \
4748
$(LUA_CFLAGS) \
4849
$(PCRE_CFLAGS) \
50+
$(PCRE2_CFLAGS) \
4951
$(LIBXML2_CFLAGS)
5052

5153

examples/reading_logs_with_offset/Makefile.am

+2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ read_LDADD = \
1414
$(LMDB_LDADD) \
1515
$(LUA_LDADD) \
1616
$(PCRE_LDADD) \
17+
$(PCRE2_LDADD) \
1718
$(SSDEEP_LDADD) \
1819
$(YAJL_LDADD)
1920

@@ -46,6 +47,7 @@ read_CPPFLAGS = \
4647
$(LMDB_CFLAGS) \
4748
$(LUA_CFLAGS) \
4849
$(PCRE_CFLAGS) \
50+
$(PCRE2_CFLAGS) \
4951
$(LIBXML2_CFLAGS)
5052

5153

examples/using_bodies_in_chunks/Makefile.am

+2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ simple_request_LDADD = \
1414
$(LMDB_LDADD) \
1515
$(LUA_LDADD) \
1616
$(PCRE_LDADD) \
17+
$(PCRE2_LDADD) \
1718
$(SSDEEP_LDADD) \
1819
$(YAJL_LDADD)
1920

@@ -46,6 +47,7 @@ simple_request_CPPFLAGS = \
4647
$(LMDB_CFLAGS) \
4748
$(LUA_CFLAGS) \
4849
$(PCRE_CFLAGS) \
50+
$(PCRE2_CFLAGS) \
4951
$(LIBXML2_CFLAGS)
5052

5153
MAINTAINERCLEANFILES = \

src/parser/Makefile.am

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ libmodsec_parser_la_CPPFLAGS = \
2525
$(YAJL_CFLAGS) \
2626
$(LMDB_CFLAGS) \
2727
$(PCRE_CFLAGS) \
28+
$(PCRE2_CFLAGS) \
2829
$(LIBXML2_CFLAGS)
2930

3031
test.cc: seclang-parser.hh

test/benchmark/Makefile.am

+2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ benchmark_LDADD = \
1010
$(GEOIP_LDADD) \
1111
$(MAXMIND_LDADD) \
1212
$(PCRE_LDADD) \
13+
$(PCRE2_LDADD) \
1314
$(YAJL_LDADD) \
1415
$(LMDB_LDADD) \
1516
$(SSDEEP_LDADD) \
@@ -35,6 +36,7 @@ benchmark_CPPFLAGS = \
3536
-I$(top_builddir)/headers \
3637
$(GLOBAL_CPPFLAGS) \
3738
$(PCRE_CFLAGS) \
39+
$(PCRE2_CFLAGS) \
3840
$(LMDB_CFLAGS) \
3941
$(LIBXML2_CFLAGS)
4042

test/fuzzer/Makefile.am

+2
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ afl_fuzzer_LDADD = \
1818
$(CURL_LDADD) \
1919
$(GEOIP_LDFLAGS) $(GEOIP_LDADD) \
2020
$(PCRE_LDADD) \
21+
$(PCRE2_LDADD) \
2122
$(YAJL_LDFLAGS) $(YAJL_LDADD) \
2223
$(LMDB_LDFLAGS) $(LMDB_LDADD) \
2324
$(MAXMIND_LDFLAGS) $(MAXMIND_LDADD) \
@@ -44,4 +45,5 @@ afl_fuzzer_CPPFLAGS = \
4445
$(YAJL_CFLAGS) \
4546
$(LMDB_CFLAGS) \
4647
$(PCRE_CFLAGS) \
48+
$(PCRE2_CFLAGS) \
4749
$(LIBXML2_CFLAGS)

tools/rules-check/Makefile.am

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ modsec_rules_check_LDADD = \
1515
$(LMDB_LDADD) \
1616
$(LUA_LDADD) \
1717
$(PCRE_LDADD) \
18+
$(PCRE2_LDADD) \
1819
$(SSDEEP_LDADD) \
1920
$(YAJL_LDADD)
2021

@@ -31,6 +32,7 @@ modsec_rules_check_CPPFLAGS = \
3132
-I$(top_builddir)/headers \
3233
$(GLOBAL_CPPFLAGS) \
3334
$(PCRE_CFLAGS) \
35+
$(PCRE2_CFLAGS) \
3436
$(LMDB_CFLAGS) \
3537
$(MAXMIND_CFLAGS) \
3638
$(LIBXML2_CFLAGS)

0 commit comments

Comments
 (0)