-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s2i with buildah support #1031
Comments
Hello @rajivml!
Yes, that's correct. Using
However, you would still need to investigate the root of this issue. Using
That's true for Using |
Thanks @otaviof , for your immediate reply on this,
Yeah true, we are investigating the issue but we are not able to pinpoint the issue, I think since we are setting the limits on the Pods the s2i container that is getting spawned is running in best effort mode and is getting killed as soon as kernel detects OOM scenario, we are trying to reduce the no of pods which are responsible for building docker images so that we throttle the requests and also we will try setting the limits on the pods well
Thanks for letting me know how s2i containers runs in DinD mode, I am not aware that the s2i container spawned runs within the same Pod which triggered the build, am under assumption that this container will be spawned on the same Node where DinD pod is running and we don't have control on this container, if it's running as a side car within the same DinD pod, then I think setting the limits on the Pod should definitely help
BTW, When are we targeting to merge this PR, any idea ? because the DinD thing was raised as an security issue as well |
@rajivml I'm afraid the support for |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/lifecycle frozen This is a feature we want for the future of s2i. |
HI,
@otaviof I have seen this PR #1003, where this feature is being implemented and just want to check, so once this PR is merged and if I switch to use buildah as my container manager then the issue that am facing here will also be resolved ?#1016, the issue that am facing in 1016 is, the s2i containers that are getting spawned are repeatedly getting killed on Kubernetes when the Nodes are under memory pressure and am not able to figure out how to avoid them getting killed .
Am assuming with this implementation i.e through buildah in place the entire logic to build a container will execute within the same pod that has triggered the build using s2i, so that the memory and cpu limits that are applicable on POD will be applicable for the s2i build as well since the build will be running inside the pod
The text was updated successfully, but these errors were encountered: