Wrong returned value from createFromFormat

[stekycz]

PHP documentation says the method should return FALSE on failure. However Nette\Utils\DateTime returns always DateTime instance.

The problem is on the line 109. I do not think there should be call of static::from. If FALSE is passed as the argument then current datetime instance is returned.

Reproduction code

Assert::false(Nette\Utils\DateTime::createFromFormat('Y-m-d', '2014-10'));

[fprochazka]

Yes, the original API was broken, and should be fixed. Can you send a pullrequest please?

[stekycz]

Yes, I definitely can. However I would just remove mentioned call of static::from. I think there is some reason why it is there so I would like to make as good as possible solution. What do you think?

[xificurk]

@stekycz The static::from is there, so that the method always returns Nette\Utils\DateTime.

[fprochazka]

it just needs to be changed to

if (returned object) change to Nette..\DateTime else return false