Problems after pull/1319

[dimkalinux]

After upgrading from 2.1RC4 to 2.1 got some problems with my projects.
First i have application-specific errors - empty collections after SQL-query. This error produces only after cache clearing on second page updating.
Second - number SQL-queries is bigger than in previous versions on some page.
Im use discovered reflections with MySQL/InnoDB.

This is query plan for Nette 2.1RC4

Cache: https://dl.dropboxusercontent.com/u/1630654/pull-nette/_Nette.Database.119856a97a539cd48bfcaf84b52ae9f5-v2.1RC4.tar.gz

This is query plan for Nette 2.1.0 its second page updating when my error produces.

Cache: https://dl.dropboxusercontent.com/u/1630654/pull-nette/_Nette.Database.119856a97a539cd48bfcaf84b52ae9f5-v2.1.0-1q.tar.gz

This is query plan for Nette 2.1.0 its third page updating.

Cache: https://dl.dropboxusercontent.com/u/1630654/pull-nette/_Nette.Database.119856a97a539cd48bfcaf84b52ae9f5-v2.1.0-2q.tar.gz

I saved database cache for each version and queries and its different in one file _0dced351a5c85f89b68107cf574be093. I think problem introduces by #1319

[hrach]

The best would be some sandbox, where it's reproducible.

[dimkalinux]

On second image is doubled query for SELECT * FROM items.
In code its

// AbstractDbMapper.php::69 SELECT not by primary key.
$row = $this->database->table($this->tableName)->where($by)->limit(1)->fetch(); 
// ItemMapper.php:40.
$row->toArray()

On v2.1 its produces 2 query, on v2.1RC4 — only one.
Table items http://thecode.punbb.org.ua/get/5QoGV95biABk3B

[dimkalinux]

@hrach you can use demo app from http://forum.nette.org/cs/16334-nette-database-undefined-offset-pri-kazdem-druhem-refreshi-prilozen-kod-pro-reprodukci

Just update HomepagePresenter and enable debug bar in bootstrap and replace vendor/nette with 2.1.0 version and clean cache (this is important). In v2.1.0 if you select row not by primary key and make $row->toArray() - Nette make second query with primary key. I think its bug.

<?php

final class HomePresenter extends BasePresenter
{
    public function renderDefault()
    {
        $newsContent = $this->context->database->table("news_content")->where("news_id", 4)->limit(1)->fetch();
        $newsContent->toArray();
        exit;
    }
}

In v2.1RC4 just 1 query, in v2.1.0 — 2 Query.