Call to an undefined method Nette\DI\Definitions\Definition::setFactory().

[janbarasek]

Version: 3.0.10

Bug Description

The new version 3.0.10 introduces a fatal bug in all my opensource packages. The following error is reported in PhpStan:

Used code snippet:

final class AdminBarExtension extends CompilerExtension
{
	public function beforeCompile(): void
	{
		$builder = $this->getContainerBuilder();
		$builder->addDefinition($this->prefix('basicPanel'))
			->setFactory(BasicPanel::class) // error is here
			->setAutowired(BasicPanel::class);
	}

May I ask why?

Steps To Reproduce

https://github.com/baraja-core/admin-bar/runs/3746137042?check_suite_focus=true

---

[mabar]

Introduced by this commit 927cf12#diff-b9daf4dddf386ed0ba9c34d1760c4e76f4591b537f1837637c40d4dba0b4ab72L58-R60

Generics probably should not be used because it's not clear what should happen when T is not defined. Even case with T defined is not clear - nothing says it will return T and not ServiceDefinition

[jaroslavlibal]

@dg Would it be possible to tag the partial revert please? So that we can remove the fixation of version 3.0.9 in composer. Thanks a lot!

[dg]

It is not such a major bug, so I will wait to release the new version.