Wrong class names for storages

[petrknap]

Please change class names of storages, because:

• MemcacheStorage doesn't exist
• MemcachedStorage doesn't support memcached extension
• NewMemcachedStorage... Shame on the author of this class name

Thanks for your time, I hope that you will change it and I will never find anything like NewNewMemchachedStorage after another memory cache extension will be released.

[hrach]

I'm the author and I was "forced" to name it like this :) Please read the whole thread here:
#38

[hrach]

This was done because it would be a BC break. I think it would be correct rename it for Nette 3.0.

[TomasVotruba]

Hi @petrknap, how would you like to see those classes named then?

@hrach Thanks for reference!

[petrknap]

@hrach That feeling when you know how to do it right, but they say BC. I'm looking forward to Nette 3 if this BC terror will be removed. :)

@TomasVotruba Simply - MemcacheStorage for memcache extension (currently MemcachedStorage) and MemcachedStorage for memcached extension (currently NewMemcachedStorage).

[dg]

@petrknap and what about compatibility?

[petrknap]

@dg Compatibility is problem, I must admit it. But this change can be part of new huge release (Nette 3, as @hrach mentioned). It is clean and logical - I can't imagine better reason for Nette 3 release than removing BC in cases when BC supports bad practices.

[dg]

It should in one release trigger warning, in second release it can be changed. If you figure out how to do it, simply send PR.