Invocation of RobotLoader

[jkuchar]

Shouldn't this be off by default?

gist: https://gist.github.com/jkuchar/4b349fad1a640fc13eb2

[jkuchar]

Found nice workaround

application:
    scanDirs: false

[fprochazka]

It should probably throw an exception, if robotloader is not installed.

[jkuchar]

I'm just curious why $config["scanDirs"] is by default evaluated to true. I'll try to print out the actualt default value.

Here it is defined as empty array by default: https://github.com/nette/application/blob/master/src/Bridges/ApplicationDI/ApplicationExtension.php#L26

PS: Cool is that when I do not load any config it skips over this error on Windows. Not on Linux. 😄

[milo]

How do you register the ApplicationExtension? The Nette Bootstrap pass %appDir%.

[hranicka]

Why is the Nette Bootstrap passes %appDir% and initializes Robot Loader by default?

Is it really necessary?

In my case (and I don't know why, maybe custom PresenterFactory) it causes DIC rebuild in each application request. And it's an expensive operation.

I solved this also by explicit config

application:
    scanDirs: no

But I don't why ApplicationExtension needs the RobotLoader.
I don't use it (Composer's autloader). And when, I configure and call it in app/bootstrap.php.

Thank you.

[dg]

It is by default, because it is the most user-friendly way. If you are using a different way, you can easily disable it.

If is DIC compiled in each request, it is a bug that needs to be addressed. Try to find reason. I think … isn't it caused by this line

application/src/Bridges/ApplicationDI/ApplicationExtension.php

Line 136 in 64606f4

$this->getContainerBuilder()->addDependency($this->tempFile);

?

[hranicka]

@dg I've found the temp file was touched every request, in here.

Because the touched file is added as a DIC dependency (as you write above), DIC was rebuild each request.

But I've found a problem a day ago and some pages don't invokes the touch. I must study it deeply.¨¨

Maybe, I should create a new issue, identify the problem and try to find a solution how to solve it.

Thank you for kicking (positively) :-)

[dg]

It is touched when you are creating instance of presenter, which is not registered in container. But it should not touch file (see

application/src/Bridges/ApplicationDI/ApplicationExtension.php

Line 72 in 64606f4

$touch = $this->debugMode && $config['scanDirs'] ? $this->tempFile : NULL;

) when scanDirs is false (or no).

You can of course disable RobotLoader, use only Composer and add all presenters to DIC manually. I see no benefit for this, but it is possible. In this case you should disable scanDirs and Nette should not compile DIC on each request.

[hranicka]

Yes, when scanDirs is FALSE it is OK and RobotLoader is not invoked and DIC is not rebuilt each request (with my custom PresenterFactory).

As I've post above.

So you say the default behaviour with RobotLoader and hidden %appDir% is correct, OK.

Thank you.

---

My problem is caused by a rare (?) application usage

• I have PSR-4 application structure, also with presenters.
• I don't use RobotLoader, but Composer's autoloader.
• I have custom PresenterFactory which allows me seperated modules loaded via Composer in different paths. (A custom PresenterFactory may not be the reason of this issue.)
• I don't register RobotLoader manually. But it's registered automatically by internall extension with %appDir% parameter. This is an underhood behaviour here and here.
• Because of this, this and this line and custom PSR-4 presenter autoloading, the DIC is rebuilt each request.

---

Fix for my PSR-4 presenters situation

application:
    # PSR-4: Do not use RobotLoader nor rebuild DIC.
    scanDirs: no

This also speeds up DIC building in my case and prevents rebuild each request (in my case). Which is significant improvement to me.

---

Another example solution which registers Presenters as services in DIC

Correctly register your Presenters paths in a config file manually, like this:

application:
    scanDirs:
        - %appDir% # This is already set by default.
        - %rootDir%/src
        - %rootDir%/vendor

---

May helps others with some issues.

I don't know which solution is faster in your situation.

I've disabled scanDir because I don't know Presenter's paths in modules. They are loaded as Composer dependencies. And I don't want register the whole root or whole vendor directory.

In my case scanDirs: no is faster. Presenters are not automatically registered as services in DIC, but I can register them manually when I need it. In a debug mode it's also faster (Robot Loader is not invoked). In production, the second solution may be faster (after DIC is already built) because all presenters are registered as services and injects are not called on-the-fly.

[dg]

Thanks for deep explanation.

I do not know what exactly is your motivation for your usage, but I would like to mention a couple of points:

• Composer autoloader without --optimize is slow
• RobotLoader is really fast
• there is no measurable difference whether you use only Composer or Composer with RobotLoader
• RobotLoader is not registered by extension, it only uses its ability to scan files, not autoloading
• creating presenter on-the-fly is slow, they should be registered in DIC

So when I want speed, I will use optimized Composer and presenters registered in DIC. When I want speed & comfort, I will use optimized Composer, presenters registered in DIC via extension (scanDirs) and RobotLoader for /app (because I don't want always execute composer dumpautoload).

[hranicka]

My problem was that DIC rebuilt each request. And I spent a lot of time with debugging it.
It occured because I didn't registered scanDirs paths for presenters in another destinations. My fault, sorry for the issue here.

Ok, for performance reasons, I correctly register all paths into scanDirs (in local develop when use Composer and its classmap is not always created and I don't want DIC rebuilt each request or run composer --dumpautoload as you write).

And I leave scanComposer as-is (when Composer autoloader classmap is generated, Nette automatically registers all presenters in DIC as services => performance).

Thank you for your help and mysterious explanation, @dg !