Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Platforms with Same Name for Different Manufacturers #17413

Open
mjoshionemind opened this issue Sep 9, 2024 · 6 comments · May be fixed by Onemind-Services-LLC/netbox#1 or #19061
Open

Allow Platforms with Same Name for Different Manufacturers #17413

mjoshionemind opened this issue Sep 9, 2024 · 6 comments · May be fixed by Onemind-Services-LLC/netbox#1 or #19061
Assignees
@abhi1693
Labels
complexity: low Requires minimal effort to implement needs milestone Awaiting prioritization for inclusion with a future NetBox release netbox type: feature Introduction of new functionality to the application

Comments

@mjoshionemind
Copy link

NetBox version

v4.0.7

Feature type

Change to existing functionality

Proposed functionality

In the Platform model, the system raises a validation error when trying to create a Platform with the same name even if the associated Manufacturer is different. This is problematic because two manufacturers can produce platforms with the same name. The system should allow Platform records with the same name if they are associated with different Manufacturers.

Use case

The Platform name should only be enforced as unique within a Manufacturer. This allows two platforms with the same name but belonging to different manufacturers to be created.

Steps to Reproduce:

Create a Manufacturer (e.g., Manufacturer A).
Create a Platform named "Test Platform" under Manufacturer A.
Create another Manufacturer (e.g., Manufacturer B).
Attempt to create another Platform named "Test Platform" under Manufacturer B.

Database changes

No response

External dependencies

No response
@mjoshionemind mjoshionemind added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Sep 9, 2024
@goteamkor
Copy link

Cisco IOS and Apple IOS come to mind.

@abhi1693
Copy link
Member

I can implement this if selected. @arthanson

@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@jeremystretch
Copy link
Member

We can support this, but it will require tweaking the device & VM import forms to also filter by manufacturer when specifying a device/VM platform. (Otherwise, attempting to import a platform referenced by name only may fail.)

@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation complexity: low Requires minimal effort to implement and removed status: needs triage This issue is awaiting triage by a maintainer labels Jan 10, 2025
@arthanson
Copy link
Collaborator

@abhi1693 would you still be open to working on this, for 4.3 release?

@abhi1693
Copy link
Member

Yes

@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Feb 13, 2025
@arthanson
Copy link
Collaborator

Assigned it to you @abhi1693 Thanks!

@rboucher-me rboucher-me added the needs milestone Awaiting prioritization for inclusion with a future NetBox release label Feb 13, 2025
@prafullpandeyOneMind prafullpandeyOneMind linked a pull request Feb 20, 2025 that will close this issue
Open
@abhi1693 abhi1693 linked a pull request Apr 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhi1693 abhi1693

Labels
complexity: low Requires minimal effort to implement needs milestone Awaiting prioritization for inclusion with a future NetBox release netbox type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
6 participants
@arthanson @abhi1693 @jeremystretch @rboucher-me @mjoshionemind @goteamkor