!self$finished is not TRUE error when running many_models()

[adammedcalf-ww]

Hi,

I'm getting this error when running many_models with default options:

"Error in pb_tick(self, private, len, tokens) : !self$finished is not TRUE"

I believe it's something to do with the processing output to the screen, as if you use the verbose = FALSE option it doesn't occur and the models are correctly created.

Thanks,

Adam

[bokov]

I had a similar problem with the following pb:

pb <- progress_bar$new(format = "  got :current rows at :tick_rate/sec, total time :elapsed, total rows :total", clear = FALSE);

It would give this error after the second time pb$tick() was called.

When I got rid of the :total in the format string, the error went away.

I don't know the details of your situation but my error seems to be caused by the total not being known in advance. This ticket might be resolved by whatever code in stmprinter calls progress$new() explicitly setting a large total argument, with slack to account for under-estimating the workload, or setting it to NA if feasible, or detecting this situation before tick() is called and e.g. setting future ticks to 0.

Hope this helps.

[bokov]

I posted a separate bug report upstream.

[mikajoh]

Having the progress bar is not strictly necessary here. Maybe we should just remove it to avoid these or future issues. What do you guys think?