Editors are marked as visible when not in the DOM

[roblourens]

Add this code to settingsEditor2.ts, layout()

		if (!DOM.isInDOM(this.rootElement)) {
			console.log('not in dom');
			return;
		} else {
			console.log('in dom');
		}

Then open two editor groups, open the settings UI in one, click the button to toggle horizontal/vertical orientation, and see that the first branch is hit.

I think that an editor should not be called "visible" if its root element is not in the DOM.

I think that this is new, because I think the if (!this.isVisible()) check was trying to fix the same issue, but it might not be new.

[sbatten]

looks like we keep everything visible during the flipNode operation and looking at it, we might break other things if we changed that behavior

/cc @joaomoreno

[joaomoreno]

We could potentially prevent layout calls during flipNode since there's an absolute layout call done right after.