Remove tslint-microsoft-contrib.

iclanton · iclanton · commit b2a729762ddb · 2024-05-28T20:57:42.000-07:00
diff --git a/build-tests-samples/heft-node-basic-tutorial/src/index.ts b/build-tests-samples/heft-node-basic-tutorial/src/index.ts
@@ -4,4 +4,4 @@
 /**
  * @public
  */
-export class TestClass {} // tslint:disable-line:export-name
+export class TestClass {}
diff --git a/build-tests-samples/heft-node-rig-tutorial/src/index.ts b/build-tests-samples/heft-node-rig-tutorial/src/index.ts
@@ -4,4 +4,4 @@
 /**
  * @public
  */
-export class TestClass {} // tslint:disable-line:export-name
+export class TestClass {}
diff --git a/build-tests-subspace/typescript-newest-test/src/index.ts b/build-tests-subspace/typescript-newest-test/src/index.ts
@@ -4,4 +4,4 @@
 /**
  * @public
  */
-export class TestClass {} // tslint:disable-line:export-name
+export class TestClass {}
diff --git a/build-tests-subspace/typescript-v4-test/src/index.ts b/build-tests-subspace/typescript-v4-test/src/index.ts
@@ -4,4 +4,4 @@
 /**
  * @public
  */
-export class TestClass {} // tslint:disable-line:export-name
+export class TestClass {}
diff --git a/build-tests/heft-node-everything-esm-module-test/package.json b/build-tests/heft-node-everything-esm-module-test/package.json
@@ -25,7 +25,6 @@
     "heft-example-plugin-01": "workspace:*",
     "heft-example-plugin-02": "workspace:*",
     "tslint": "~5.20.1",
-    "tslint-microsoft-contrib": "~6.2.0",
     "typescript": "~5.4.2"
   }
 }
diff --git a/build-tests/heft-node-everything-esm-module-test/src/index.ts b/build-tests/heft-node-everything-esm-module-test/src/index.ts
@@ -4,4 +4,4 @@
 /**
  * @public
  */
-export class TestClass {} // tslint:disable-line:export-name
+export class TestClass {}
diff --git a/build-tests/heft-node-everything-esm-module-test/tslint.json b/build-tests/heft-node-everything-esm-module-test/tslint.json
@@ -1,13 +1,11 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
 
-  "rulesDirectory": ["tslint-microsoft-contrib"],
   "rules": {
     "class-name": true,
     "comment-format": [true, "check-space"],
     "curly": true,
     "eofline": false,
-    "export-name": true,
     "forin": true,
     "indent": [true, "spaces", 2],
     "interface-name": true,
@@ -36,32 +34,26 @@
         ]
       }
     ],
-    "missing-optional-annotation": true,
     "no-arg": true,
     "no-any": true,
     "no-bitwise": true,
     "no-consecutive-blank-lines": true,
     "no-console": [true, "debug", "info", "time", "timeEnd", "trace"],
-    "no-constant-condition": true,
     "no-construct": true,
     "no-debugger": true,
     "no-duplicate-switch-case": true,
-    "no-duplicate-parameter-names": true,
     "no-duplicate-variable": true,
     "no-empty": true,
     "no-eval": true,
     "no-floating-promises": true,
-    "no-function-expression": true,
     "no-inferrable-types": false,
     "no-internal-module": true,
     "no-null-keyword": true,
     "no-shadowed-variable": true,
     "no-string-literal": true,
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
-    "no-unnecessary-semicolons": true,
     "no-unused-expression": true,
-    "no-with-statement": true,
     "no-var-keyword": true,
     "object-literal-sort-keys": false,
     "one-line": [true, "check-open-brace", "check-catch", "check-else", "check-whitespace"],
@@ -96,7 +88,6 @@
       }
     ],
     "use-isnan": true,
-    "use-named-parameter": true,
     "variable-name": [true, "check-format", "allow-leading-underscore", "ban-keywords"],
     "whitespace": [true, "check-branch", "check-decl", "check-operator", "check-separator", "check-type"]
   }
diff --git a/build-tests/heft-node-everything-test/package.json b/build-tests/heft-node-everything-test/package.json
@@ -24,7 +24,6 @@
     "heft-example-plugin-01": "workspace:*",
     "heft-example-plugin-02": "workspace:*",
     "tslint": "~5.20.1",
-    "tslint-microsoft-contrib": "~6.2.0",
     "typescript": "~5.4.2"
   }
 }
diff --git a/build-tests/heft-node-everything-test/src/index.ts b/build-tests/heft-node-everything-test/src/index.ts
@@ -4,4 +4,4 @@
 /**
  * @public
  */
-export class TestClass {} // tslint:disable-line:export-name
+export class TestClass {}
diff --git a/build-tests/heft-node-everything-test/tslint.json b/build-tests/heft-node-everything-test/tslint.json
@@ -1,13 +1,11 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
 
-  "rulesDirectory": ["tslint-microsoft-contrib"],
   "rules": {
     "class-name": true,
     "comment-format": [true, "check-space"],
     "curly": true,
     "eofline": false,
-    "export-name": true,
     "forin": true,
     "indent": [true, "spaces", 2],
     "interface-name": true,
@@ -36,32 +34,26 @@
         ]
       }
     ],
-    "missing-optional-annotation": true,
     "no-arg": true,
     "no-any": true,
     "no-bitwise": true,
     "no-consecutive-blank-lines": true,
     "no-console": [true, "debug", "info", "time", "timeEnd", "trace"],
-    "no-constant-condition": true,
     "no-construct": true,
     "no-debugger": true,
     "no-duplicate-switch-case": true,
-    "no-duplicate-parameter-names": true,
     "no-duplicate-variable": true,
     "no-empty": true,
     "no-eval": true,
     "no-floating-promises": true,
-    "no-function-expression": true,
     "no-inferrable-types": false,
     "no-internal-module": true,
     "no-null-keyword": true,
     "no-shadowed-variable": true,
     "no-string-literal": true,
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
-    "no-unnecessary-semicolons": true,
     "no-unused-expression": true,
-    "no-with-statement": true,
     "no-var-keyword": true,
     "object-literal-sort-keys": false,
     "one-line": [true, "check-open-brace", "check-catch", "check-else", "check-whitespace"],
@@ -96,7 +88,6 @@
       }
     ],
     "use-isnan": true,
-    "use-named-parameter": true,
     "variable-name": [true, "check-format", "allow-leading-underscore", "ban-keywords"],
     "whitespace": [true, "check-branch", "check-decl", "check-operator", "check-separator", "check-type"]
   }
diff --git a/build-tests/heft-typescript-composite-test/package.json b/build-tests/heft-typescript-composite-test/package.json
@@ -20,7 +20,6 @@
     "@types/webpack-env": "1.18.0",
     "eslint": "~8.57.0",
     "tslint": "~5.20.1",
-    "tslint-microsoft-contrib": "~6.2.0",
     "typescript": "~5.4.2"
   }
 }
diff --git a/build-tests/heft-typescript-composite-test/tslint.json b/build-tests/heft-typescript-composite-test/tslint.json
@@ -1,13 +1,11 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
 
-  "rulesDirectory": ["tslint-microsoft-contrib"],
   "rules": {
     "class-name": true,
     "comment-format": [true, "check-space"],
     "curly": true,
     "eofline": false,
-    "export-name": true,
     "forin": true,
     "indent": [true, "spaces", 2],
     "interface-name": true,
@@ -36,22 +34,18 @@
         ]
       }
     ],
-    "missing-optional-annotation": true,
     "no-arg": true,
     "no-any": true,
     "no-bitwise": true,
     "no-consecutive-blank-lines": true,
     "no-console": [true, "debug", "info", "time", "timeEnd", "trace"],
-    "no-constant-condition": true,
     "no-construct": true,
     "no-debugger": true,
     "no-duplicate-switch-case": true,
-    "no-duplicate-parameter-names": true,
     "no-duplicate-variable": true,
     "no-empty": true,
     "no-eval": true,
     "no-floating-promises": true,
-    "no-function-expression": true,
     "no-inferrable-types": false,
     "no-internal-module": true,
     "no-null-keyword": true,
@@ -62,9 +56,7 @@
     "no-string-literal": true,
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
-    "no-unnecessary-semicolons": true,
     "no-unused-expression": true,
-    "no-with-statement": true,
     "no-var-keyword": true,
     "object-literal-sort-keys": false,
     "one-line": [true, "check-open-brace", "check-catch", "check-else", "check-whitespace"],
@@ -99,7 +91,6 @@
       }
     ],
     "use-isnan": true,
-    "use-named-parameter": true,
     "variable-name": [true, "check-format", "allow-leading-underscore", "ban-keywords"],
     "whitespace": [true, "check-branch", "check-decl", "check-operator", "check-separator", "check-type"]
   }
diff --git a/build-tests/heft-typescript-v2-test/package.json b/build-tests/heft-typescript-v2-test/package.json
@@ -20,7 +20,6 @@
     "@types/jest": "ts2.9",
     "@types/node": "ts2.9",
     "tslint": "~5.20.1",
-    "tslint-microsoft-contrib": "~6.2.0",
     "typescript": "~2.9.2"
   }
 }
diff --git a/build-tests/heft-typescript-v2-test/src/index.ts b/build-tests/heft-typescript-v2-test/src/index.ts
@@ -4,4 +4,4 @@
 /**
  * @public
  */
-export class TestClass {} // tslint:disable-line:export-name
+export class TestClass {}
diff --git a/build-tests/heft-typescript-v2-test/tslint.json b/build-tests/heft-typescript-v2-test/tslint.json
@@ -1,13 +1,11 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
 
-  "rulesDirectory": ["tslint-microsoft-contrib"],
   "rules": {
     "class-name": true,
     "comment-format": [true, "check-space"],
     "curly": true,
     "eofline": false,
-    "export-name": true,
     "forin": true,
     "indent": [true, "spaces", 2],
     "interface-name": true,
@@ -36,32 +34,26 @@
         ]
       }
     ],
-    "missing-optional-annotation": true,
     "no-arg": true,
     "no-any": true,
     "no-bitwise": true,
     "no-consecutive-blank-lines": true,
     "no-console": [true, "debug", "info", "time", "timeEnd", "trace"],
-    "no-constant-condition": true,
     "no-construct": true,
     "no-debugger": true,
     "no-duplicate-switch-case": true,
-    "no-duplicate-parameter-names": true,
     "no-duplicate-variable": true,
     "no-empty": true,
     "no-eval": true,
     "no-floating-promises": true,
-    "no-function-expression": true,
     "no-inferrable-types": false,
     "no-internal-module": true,
     "no-null-keyword": true,
     "no-shadowed-variable": true,
     "no-string-literal": true,
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
-    "no-unnecessary-semicolons": true,
     "no-unused-expression": true,
-    "no-with-statement": true,
     "no-var-keyword": true,
     "object-literal-sort-keys": false,
     "one-line": [true, "check-open-brace", "check-catch", "check-else", "check-whitespace"],
@@ -96,7 +88,6 @@
       }
     ],
     "use-isnan": true,
-    "use-named-parameter": true,
     "variable-name": [true, "check-format", "allow-leading-underscore", "ban-keywords"],
     "whitespace": [true, "check-branch", "check-decl", "check-operator", "check-separator", "check-type"]
   }
diff --git a/build-tests/heft-typescript-v3-test/package.json b/build-tests/heft-typescript-v3-test/package.json
@@ -20,7 +20,6 @@
     "@types/jest": "ts3.9",
     "@types/node": "ts3.9",
     "tslint": "~5.20.1",
-    "tslint-microsoft-contrib": "~6.2.0",
     "typescript": "~3.9.10"
   }
 }
diff --git a/build-tests/heft-typescript-v3-test/src/index.ts b/build-tests/heft-typescript-v3-test/src/index.ts
@@ -4,4 +4,4 @@
 /**
  * @public
  */
-export class TestClass {} // tslint:disable-line:export-name
+export class TestClass {}
diff --git a/build-tests/heft-typescript-v3-test/tslint.json b/build-tests/heft-typescript-v3-test/tslint.json
@@ -1,13 +1,11 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
 
-  "rulesDirectory": ["tslint-microsoft-contrib"],
   "rules": {
     "class-name": true,
     "comment-format": [true, "check-space"],
     "curly": true,
     "eofline": false,
-    "export-name": true,
     "forin": true,
     "indent": [true, "spaces", 2],
     "interface-name": true,
@@ -36,32 +34,26 @@
         ]
       }
     ],
-    "missing-optional-annotation": true,
     "no-arg": true,
     "no-any": true,
     "no-bitwise": true,
     "no-consecutive-blank-lines": true,
     "no-console": [true, "debug", "info", "time", "timeEnd", "trace"],
-    "no-constant-condition": true,
     "no-construct": true,
     "no-debugger": true,
     "no-duplicate-switch-case": true,
-    "no-duplicate-parameter-names": true,
     "no-duplicate-variable": true,
     "no-empty": true,
     "no-eval": true,
     "no-floating-promises": true,
-    "no-function-expression": true,
     "no-inferrable-types": false,
     "no-internal-module": true,
     "no-null-keyword": true,
     "no-shadowed-variable": true,
     "no-string-literal": true,
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
-    "no-unnecessary-semicolons": true,
     "no-unused-expression": true,
-    "no-with-statement": true,
     "no-var-keyword": true,
     "object-literal-sort-keys": false,
     "one-line": [true, "check-open-brace", "check-catch", "check-else", "check-whitespace"],
@@ -96,7 +88,6 @@
       }
     ],
     "use-isnan": true,
-    "use-named-parameter": true,
     "variable-name": [true, "check-format", "allow-leading-underscore", "ban-keywords"],
     "whitespace": [true, "check-branch", "check-decl", "check-operator", "check-separator", "check-type"]
   }
diff --git a/build-tests/heft-typescript-v4-test/package.json b/build-tests/heft-typescript-v4-test/package.json
@@ -23,7 +23,6 @@
     "@types/node": "ts4.9",
     "eslint": "~8.57.0",
     "tslint": "~5.20.1",
-    "tslint-microsoft-contrib": "~6.2.0",
     "typescript": "~4.9.5"
   }
 }
diff --git a/build-tests/heft-typescript-v4-test/src/index.ts b/build-tests/heft-typescript-v4-test/src/index.ts
@@ -4,4 +4,4 @@
 /**
  * @public
  */
-export class TestClass {} // tslint:disable-line:export-name
+export class TestClass {}
diff --git a/build-tests/heft-typescript-v4-test/tslint.json b/build-tests/heft-typescript-v4-test/tslint.json
diff --git a/build-tests/heft-webpack4-everything-test/package.json b/build-tests/heft-webpack4-everything-test/package.json
diff --git a/build-tests/heft-webpack4-everything-test/tslint.json b/build-tests/heft-webpack4-everything-test/tslint.json
diff --git a/build-tests/heft-webpack5-everything-test/package.json b/build-tests/heft-webpack5-everything-test/package.json
diff --git a/build-tests/heft-webpack5-everything-test/tslint.json b/build-tests/heft-webpack5-everything-test/tslint.json
diff --git a/common/config/rush/nonbrowser-approved-packages.json b/common/config/rush/nonbrowser-approved-packages.json
diff --git a/common/config/subspaces/build-tests-subspace/.pnpmfile-subspace.cjs b/common/config/subspaces/build-tests-subspace/.pnpmfile-subspace.cjs
diff --git a/common/config/subspaces/default/.pnpmfile-subspace.cjs b/common/config/subspaces/default/.pnpmfile-subspace.cjs

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@`
`25`	`25`	`"heft-example-plugin-01": "workspace:*",`
`26`	`26`	`"heft-example-plugin-02": "workspace:*",`
`27`	`27`	`"tslint": "~5.20.1",`
`28`		`- "tslint-microsoft-contrib": "~6.2.0",`
`29`	`28`	`"typescript": "~5.4.2"`
`30`	`29`	`}`
`31`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@`
`24`	`24`	`"heft-example-plugin-01": "workspace:*",`
`25`	`25`	`"heft-example-plugin-02": "workspace:*",`
`26`	`26`	`"tslint": "~5.20.1",`
`27`		`- "tslint-microsoft-contrib": "~6.2.0",`
`28`	`27`	`"typescript": "~5.4.2"`
`29`	`28`	`}`
`30`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@`
`20`	`20`	`"@types/webpack-env": "1.18.0",`
`21`	`21`	`"eslint": "~8.57.0",`
`22`	`22`	`"tslint": "~5.20.1",`
`23`		`- "tslint-microsoft-contrib": "~6.2.0",`
`24`	`23`	`"typescript": "~5.4.2"`
`25`	`24`	`}`
`26`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@`
`23`	`23`	`"@types/node": "ts4.9",`
`24`	`24`	`"eslint": "~8.57.0",`
`25`	`25`	`"tslint": "~5.20.1",`
`26`		`- "tslint-microsoft-contrib": "~6.2.0",`
`27`	`26`	`"typescript": "~4.9.5"`
`28`	`27`	`}`
`29`	`28`	`}`