Skip to content

Commit 5642587

Browse files
committed
Update API review.
1 parent 3e1efaa commit 5642587

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

common/reviews/api/rush-amazon-s3-build-cache-plugin.api.md

+8-10
Original file line numberDiff line numberDiff line change
@@ -30,27 +30,25 @@ export class AmazonS3Client {
3030
}
3131

3232
// @public
33-
export interface IAmazonS3BuildCacheProviderOptionsAdvanced {
34-
// (undocumented)
35-
isCacheWriteAllowed: boolean;
33+
export interface IAmazonS3BuildCacheProviderOptionsAdvanced extends IAmazonS3BuildCacheProviderOptionsBase {
3634
// (undocumented)
3735
s3Endpoint: string;
36+
}
37+
38+
// @public (undocumented)
39+
export interface IAmazonS3BuildCacheProviderOptionsBase {
40+
// (undocumented)
41+
isCacheWriteAllowed: boolean;
3842
// (undocumented)
3943
s3Prefix: string | undefined;
4044
// (undocumented)
4145
s3Region: string;
4246
}
4347

4448
// @public
45-
export interface IAmazonS3BuildCacheProviderOptionsSimple {
46-
// (undocumented)
47-
isCacheWriteAllowed: boolean;
49+
export interface IAmazonS3BuildCacheProviderOptionsSimple extends IAmazonS3BuildCacheProviderOptionsBase {
4850
// (undocumented)
4951
s3Bucket: string;
50-
// (undocumented)
51-
s3Prefix: string | undefined;
52-
// (undocumented)
53-
s3Region: string;
5452
}
5553

5654
// @public

rush-plugins/rush-amazon-s3-build-cache-plugin/src/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ export { AmazonS3Client, IAmazonS3Credentials } from './AmazonS3Client';
77
export { WebClient, IGetFetchOptions, IPutFetchOptions, WebClientResponse } from './WebClient';
88
export default RushAmazonS3BuildCachePlugin;
99
export {
10+
IAmazonS3BuildCacheProviderOptionsBase,
1011
IAmazonS3BuildCacheProviderOptionsAdvanced,
1112
IAmazonS3BuildCacheProviderOptionsSimple
1213
} from './AmazonS3BuildCacheProvider';

0 commit comments

Comments
 (0)